Before validating a STUN packet, check it's big enough for a header.

Before validating a STUN packet, check it's big enough for a header.

Otherwise, we'll read out of bounds if the packet is too small.

NOTRY=true

Committed: https://crrev.com/e4bda2437691dc57a8ab62500801ed0d487b0f80
Cr-Commit-Position: refs/heads/master@{#13093}

[katrielc, 2016-06-08 13:53:21]

katrielc@chromium.org changed reviewers:
+ henrikg@webrtc.org, katrielc@chromium.org

[katrielc, 2016-06-08 13:53:21]

Are you the right person for this? Hopefully an easy review :)

NB no current WebRTC code paths hit this since all the calls to ValidatePacket
have a size check earlier, but I think this function should still work for any
incoming data.

[Henrik Grunell WebRTC, 2016-06-09 11:31:00]

Either add a bug or remove the BUG= line.

lgtm

[katrielc1, 2016-06-09 12:00:28]

Description was changed from

==========
Before validating a STUN packet, check it's big enough for a header.

Otherwise, we'll read out of bounds if the packet is too small.

BUG=
==========

to

==========
Before validating a STUN packet, check it's big enough for a header.

Otherwise, we'll read out of bounds if the packet is too small.
==========

[katrielc1, 2016-06-09 12:01:02]

The CQ bit was checked by katrielc@webrtc.org

[commit-bot: I haz the power, 2016-06-09 12:01:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040953003/1

[commit-bot: I haz the power, 2016-06-09 12:12:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 12:12:34]

Try jobs failed on following builders:
  android_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/14045)

[katrielc1, 2016-06-09 15:43:59]

Description was changed from

==========
Before validating a STUN packet, check it's big enough for a header.

Otherwise, we'll read out of bounds if the packet is too small.
==========

to

==========
Before validating a STUN packet, check it's big enough for a header.

Otherwise, we'll read out of bounds if the packet is too small.

NOTRY=true
==========

[katrielc1, 2016-06-09 15:44:06]

The CQ bit was checked by katrielc@webrtc.org

[commit-bot: I haz the power, 2016-06-09 15:44:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040953003/1

[commit-bot: I haz the power, 2016-06-09 15:45:47]

Description was changed from

==========
Before validating a STUN packet, check it's big enough for a header.

Otherwise, we'll read out of bounds if the packet is too small.

NOTRY=true
==========

to

==========
Before validating a STUN packet, check it's big enough for a header.

Otherwise, we'll read out of bounds if the packet is too small.

NOTRY=true
==========

[commit-bot: I haz the power, 2016-06-09 15:45:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-09 15:45:58]

Description was changed from

==========
Before validating a STUN packet, check it's big enough for a header.

Otherwise, we'll read out of bounds if the packet is too small.

NOTRY=true
==========

to

==========
Before validating a STUN packet, check it's big enough for a header.

Otherwise, we'll read out of bounds if the packet is too small.

NOTRY=true

Committed: https://crrev.com/e4bda2437691dc57a8ab62500801ed0d487b0f80
Cr-Commit-Position: refs/heads/master@{#13093}
==========

[commit-bot: I haz the power, 2016-06-09 15:45:59]

Patchset 1 (id:??) landed as
https://crrev.com/e4bda2437691dc57a8ab62500801ed0d487b0f80
Cr-Commit-Position: refs/heads/master@{#13093}