Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 6 months ago by katrielc1 Modified:
4 years, 6 months ago Reviewers:
Henrik Grunell WebRTC, katrielc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionBefore validating a STUN packet, check it's big enough for a header.
Otherwise, we'll read out of bounds if the packet is too small.
NOTRY=true
Committed: https://crrev.com/e4bda2437691dc57a8ab62500801ed0d487b0f80
Cr-Commit-Position: refs/heads/master@{#13093}
Patch Set 1 #
Created: 4 years, 6 months ago
Messages
Total messages: 15 (8 generated)
katrielc@chromium.org changed reviewers: + henrikg@webrtc.org, katrielc@chromium.org
Are you the right person for this? Hopefully an easy review :) NB no current WebRTC code paths hit this since all the calls to ValidatePacket have a size check earlier, but I think this function should still work for any incoming data.
Either add a bug or remove the BUG= line. lgtm
Description was changed from ========== Before validating a STUN packet, check it's big enough for a header. Otherwise, we'll read out of bounds if the packet is too small. BUG= ========== to ========== Before validating a STUN packet, check it's big enough for a header. Otherwise, we'll read out of bounds if the packet is too small. ==========
The CQ bit was checked by katrielc@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040953003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/14045)
Description was changed from ========== Before validating a STUN packet, check it's big enough for a header. Otherwise, we'll read out of bounds if the packet is too small. ========== to ========== Before validating a STUN packet, check it's big enough for a header. Otherwise, we'll read out of bounds if the packet is too small. NOTRY=true ==========
The CQ bit was checked by katrielc@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040953003/1
Message was sent while issue was closed.
Description was changed from ========== Before validating a STUN packet, check it's big enough for a header. Otherwise, we'll read out of bounds if the packet is too small. NOTRY=true ========== to ========== Before validating a STUN packet, check it's big enough for a header. Otherwise, we'll read out of bounds if the packet is too small. NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Before validating a STUN packet, check it's big enough for a header. Otherwise, we'll read out of bounds if the packet is too small. NOTRY=true ========== to ========== Before validating a STUN packet, check it's big enough for a header. Otherwise, we'll read out of bounds if the packet is too small. NOTRY=true Committed: https://crrev.com/e4bda2437691dc57a8ab62500801ed0d487b0f80 Cr-Commit-Position: refs/heads/master@{#13093} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e4bda2437691dc57a8ab62500801ed0d487b0f80 Cr-Commit-Position: refs/heads/master@{#13093} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
