Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2040073002: GN: Add common_audio_unittests and common_video_unittests (Closed)

Created:
4 years, 6 months ago by kjellander_webrtc
Modified:
4 years, 6 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, peah-webrtc, minyue-webrtc, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Add common_audio_unittests and common_video_unittests BUG=webrtc:5949 TESTED=Built and ran the tests on Mac. NOTRY=True Committed: https://crrev.com/2a3892ac64a073851adbea40816a5962fe45e539 Cr-Commit-Position: refs/heads/master@{#13061}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -0 lines) Patch
M webrtc/common_audio/BUILD.gn View 1 2 chunks +64 lines, -0 lines 0 comments Download
M webrtc/common_video/BUILD.gn View 1 2 chunks +49 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kjellander_webrtc
4 years, 6 months ago (2016-06-06 20:52:10 UTC) #3
phoglund
lgtm
4 years, 6 months ago (2016-06-07 05:56:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040073002/20001
4 years, 6 months ago (2016-06-08 08:26:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-08 08:27:57 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 08:28:21 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2a3892ac64a073851adbea40816a5962fe45e539
Cr-Commit-Position: refs/heads/master@{#13061}

Powered by Google App Engine
This is Rietveld 408576698