Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2039353002: Fix issue with parsing of incorrect (empty) Stap-A H264 NAL units. (Closed)

Created:
4 years, 6 months ago by sprang_webrtc
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix issue with parsing of incorrect (empty) Stap-A H264 NAL units. Stap-A packets should be ignored if NAL unit size is less than one, since that won't even fit the mandatory type header byte. BUG=chromium:617097 R=pbos@webrtc.org, stefan@webrtc.org Committed: https://crrev.com/6ebdf6b2cc0f3af30c95a085215cd05b91213a21 Cr-Commit-Position: refs/heads/master@{#13057}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
sprang_webrtc
4 years, 6 months ago (2016-06-06 20:25:58 UTC) #2
pbos-webrtc
lgtm
4 years, 6 months ago (2016-06-06 20:28:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039353002/1
4 years, 6 months ago (2016-06-06 20:58:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6110)
4 years, 6 months ago (2016-06-06 21:02:14 UTC) #8
sprang_webrtc
+stefan as owner
4 years, 6 months ago (2016-06-06 21:05:54 UTC) #10
stefan-webrtc
lgtm
4 years, 6 months ago (2016-06-07 15:52:14 UTC) #11
sprang_webrtc
4 years, 6 months ago (2016-06-07 16:01:44 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6ebdf6b2cc0f3af30c95a085215cd05b91213a21 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698