Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: webrtc/video_receive_stream.h

Issue 2039053002: Make VideoReceiveStream not inherit from I420FrameCallback. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/video/video_stream_decoder.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 std::string sync_group; 161 std::string sync_group;
162 162
163 // Called for each incoming video frame, i.e. in encoded state. E.g. used 163 // Called for each incoming video frame, i.e. in encoded state. E.g. used
164 // when 164 // when
165 // saving the stream to a file. 'nullptr' disables the callback. 165 // saving the stream to a file. 'nullptr' disables the callback.
166 EncodedFrameObserver* pre_decode_callback = nullptr; 166 EncodedFrameObserver* pre_decode_callback = nullptr;
167 167
168 // Called for each decoded frame. E.g. used when adding effects to the 168 // Called for each decoded frame. E.g. used when adding effects to the
169 // decoded 169 // decoded
170 // stream. 'nullptr' disables the callback. 170 // stream. 'nullptr' disables the callback.
171 // TODO(tommi): This seems to be only used by a test or two. Consider
172 // removing it (and use an appropriate alternative in the tests) as well
173 // as the associated code in VideoStreamDecoder.
171 I420FrameCallback* pre_render_callback = nullptr; 174 I420FrameCallback* pre_render_callback = nullptr;
172 175
173 // Target delay in milliseconds. A positive value indicates this stream is 176 // Target delay in milliseconds. A positive value indicates this stream is
174 // used for streaming instead of a real-time call. 177 // used for streaming instead of a real-time call.
175 int target_delay_ms = 0; 178 int target_delay_ms = 0;
176 }; 179 };
177 180
178 // Starts stream activity. 181 // Starts stream activity.
179 // When a stream is active, it can receive, process and deliver packets. 182 // When a stream is active, it can receive, process and deliver packets.
180 virtual void Start() = 0; 183 virtual void Start() = 0;
181 // Stops stream activity. 184 // Stops stream activity.
182 // When a stream is stopped, it can't receive, process or deliver packets. 185 // When a stream is stopped, it can't receive, process or deliver packets.
183 virtual void Stop() = 0; 186 virtual void Stop() = 0;
184 187
185 // TODO(pbos): Add info on currently-received codec to Stats. 188 // TODO(pbos): Add info on currently-received codec to Stats.
186 virtual Stats GetStats() const = 0; 189 virtual Stats GetStats() const = 0;
187 190
188 protected: 191 protected:
189 virtual ~VideoReceiveStream() {} 192 virtual ~VideoReceiveStream() {}
190 }; 193 };
191 194
192 } // namespace webrtc 195 } // namespace webrtc
193 196
194 #endif // WEBRTC_VIDEO_RECEIVE_STREAM_H_ 197 #endif // WEBRTC_VIDEO_RECEIVE_STREAM_H_
OLDNEW
« no previous file with comments | « webrtc/video/video_stream_decoder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698