Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 2039053002: Make VideoReceiveStream not inherit from I420FrameCallback. (Closed)

Created:
4 years, 6 months ago by tommi
Modified:
4 years, 6 months ago
Reviewers:
pbos-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make VideoReceiveStream not inherit from I420FrameCallback. There's no need for it as the current implementation only exists as a middle layer between the decoder and the eventual callback. R=mflodman@webrtc.org, pbos@webrtc.org Committed: https://crrev.com/bd3380ff7ebfa4558db5b39fe723dab1be3fdfaa Cr-Commit-Position: refs/heads/master@{#13101}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M webrtc/video/video_receive_stream.h View 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M webrtc/video/video_stream_decoder.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M webrtc/video_receive_stream.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
tommi
4 years, 6 months ago (2016-06-04 16:28:07 UTC) #2
pbos-webrtc
fwiw drive-by lgtm
4 years, 6 months ago (2016-06-06 16:24:00 UTC) #4
tommi
ping magnus
4 years, 6 months ago (2016-06-10 14:21:21 UTC) #5
mflodman
lgtm
4 years, 6 months ago (2016-06-10 14:25:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039053002/1
4 years, 6 months ago (2016-06-10 14:28:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14081)
4 years, 6 months ago (2016-06-10 14:36:52 UTC) #10
tommi
4 years, 6 months ago (2016-06-10 15:38:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bd3380ff7ebfa4558db5b39fe723dab1be3fdfaa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698