Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2037633002:
Change VCMFrameBuffer and VCMEncodedFrame to use rotation from base class EncodedImage. (Closed)
|
Created:
4 years, 6 months ago by perkj_webrtc Modified:
4 years, 5 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionChange VCMFrameBuffer and VCMEncodedFrame to use rotation from base class EncodedImage.
BUG=webrtc:5687
Committed: https://crrev.com/414dda1a10d465ee61b0a52f036b854dc0e00739
Cr-Commit-Position: refs/heads/master@{#13376}
Patch Set 1 #Patch Set 2 : Rebased #
Messages
Total messages: 30 (13 generated)
perkj@webrtc.org changed reviewers: + philipel@webrtc.org
Please?
lgtm
The CQ bit was checked by perkj@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2037633002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6035)
perkj@webrtc.org changed reviewers: + stefan@webrtc.org
Needs owners approval.
ping Stefan.
lgtm
lgtm
The CQ bit was checked by perkj@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037633002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/14102)
The CQ bit was checked by perkj@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from philipel@webrtc.org, stefan@webrtc.org Link to the patchset: https://codereview.webrtc.org/2037633002/#ps20001 (title: "Rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_clang_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_clang_dbg/builds/4330)
The CQ bit was checked by perkj@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14497)
The CQ bit was checked by perkj@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Change VCMFrameBuffer and VCMEncodedFrame to use rotation from base class EncodedImage. BUG=webrtc:5687 ========== to ========== Change VCMFrameBuffer and VCMEncodedFrame to use rotation from base class EncodedImage. BUG=webrtc:5687 Committed: https://crrev.com/414dda1a10d465ee61b0a52f036b854dc0e00739 Cr-Commit-Position: refs/heads/master@{#13376} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/414dda1a10d465ee61b0a52f036b854dc0e00739 Cr-Commit-Position: refs/heads/master@{#13376} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
