Allow 100 char lines for ObjC files.

Allow 100 char lines for ObjC files.

NOTRY=True

BUG=

Committed: https://crrev.com/3cd9a30f96ff31e1bd5ae51dd9e7790da94c8b29
Cr-Commit-Position: refs/heads/master@{#13076}

[tkchin_webrtc, 2016-06-03 19:16:32]

Description was changed from

==========
Allow 100 char lines for ObjC files.

BUG=
==========

to

==========
Allow 100 char lines for ObjC files.

BUG=
==========

[tkchin_webrtc, 2016-06-03 19:16:32]

tkchin@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2016-06-06 17:01:07]

lgtm with suggestion regarding adding Java as well (will require updating the CL
title/description as well).

Please use NOTRY=True for this one as well.

https://codereview.webrtc.org/2037173002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/2037173002/diff/1/PRESUBMIT.py#newcode459
PRESUBMIT.py:459: objc_filter_list = (r'.+\.m$', r'.+\.mm$', r'.+objc\/.+\.h$')
While we're at it, could you add .java to the list here?
Chromium (http://dev.chromium.org/developers/coding-style/java) refers to
http://source.android.com/source/code-style.html#limit-line-length, which says
100 chars max.

[tkchin_webrtc, 2016-06-06 19:04:29]

Description was changed from

==========
Allow 100 char lines for ObjC files.

BUG=
==========

to

==========
Allow 100 char lines for ObjC files.

NOTRY=True

BUG=
==========

[tkchin_webrtc, 2016-06-06 19:06:37]

On 2016/06/06 17:01:07, kjellander_webrtc wrote:
> lgtm with suggestion regarding adding Java as well (will require updating the
CL
> title/description as well).
> 
> Please use NOTRY=True for this one as well.
> 
> https://codereview.webrtc.org/2037173002/diff/1/PRESUBMIT.py
> File PRESUBMIT.py (right):
> 
> https://codereview.webrtc.org/2037173002/diff/1/PRESUBMIT.py#newcode459
> PRESUBMIT.py:459: objc_filter_list = (r'.+\.m$', r'.+\.mm$',
r'.+objc\/.+\.h$')
> While we're at it, could you add .java to the list here?
> Chromium (http://dev.chromium.org/developers/coding-style/java) refers to
> http://source.android.com/source/code-style.html#limit-line-length, which says
> 100 chars max.

The depot_tools script already makes an exception for java I believe?
https://cs-staging.chromium.org/chromium/tools/depot_tools/presubmit_canned_c...

[kjellander_webrtc, 2016-06-06 19:09:37]

On 2016/06/06 19:06:37, tkchin_webrtc wrote:
> On 2016/06/06 17:01:07, kjellander_webrtc wrote:
> > lgtm with suggestion regarding adding Java as well (will require updating
the
> CL
> > title/description as well).
> > 
> > Please use NOTRY=True for this one as well.
> > 
> > https://codereview.webrtc.org/2037173002/diff/1/PRESUBMIT.py
> > File PRESUBMIT.py (right):
> > 
> > https://codereview.webrtc.org/2037173002/diff/1/PRESUBMIT.py#newcode459
> > PRESUBMIT.py:459: objc_filter_list = (r'.+\.m$', r'.+\.mm$',
> r'.+objc\/.+\.h$')
> > While we're at it, could you add .java to the list here?
> > Chromium (http://dev.chromium.org/developers/coding-style/java) refers to
> > http://source.android.com/source/code-style.html#limit-line-length, which
says
> > 100 chars max.
> 
> The depot_tools script already makes an exception for java I believe?
>
https://cs-staging.chromium.org/chromium/tools/depot_tools/presubmit_canned_c...

Ah, I didn't know. Then let's submit this as-is.

[tkchin_webrtc, 2016-06-08 19:37:04]

The CQ bit was checked by tkchin@webrtc.org

[commit-bot: I haz the power, 2016-06-08 19:37:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2037173002/1

[commit-bot: I haz the power, 2016-06-08 19:40:30]

Description was changed from

==========
Allow 100 char lines for ObjC files.

NOTRY=True

BUG=
==========

to

==========
Allow 100 char lines for ObjC files.

NOTRY=True

BUG=
==========

[commit-bot: I haz the power, 2016-06-08 19:40:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-08 19:40:43]

Description was changed from

==========
Allow 100 char lines for ObjC files.

NOTRY=True

BUG=
==========

to

==========
Allow 100 char lines for ObjC files.

NOTRY=True

BUG=

Committed: https://crrev.com/3cd9a30f96ff31e1bd5ae51dd9e7790da94c8b29
Cr-Commit-Position: refs/heads/master@{#13076}
==========

[commit-bot: I haz the power, 2016-06-08 19:40:44]

Patchset 1 (id:??) landed as
https://crrev.com/3cd9a30f96ff31e1bd5ae51dd9e7790da94c8b29
Cr-Commit-Position: refs/heads/master@{#13076}