Add ObjC API for getting native histograms.

Add ObjC API for getting native histograms.

BUG=

Committed: https://crrev.com/0ab07d67cb59352235d7d2a38df2e12f7fe80865
Cr-Commit-Position: refs/heads/master@{#13064}

[åsapersson, 2016-06-03 14:03:56]

Description was changed from

==========
Add ObjC API for getting native histograms.

BUG=
==========

to

==========
Add ObjC API for getting native histograms.

BUG=
==========

[åsapersson, 2016-06-03 14:03:56]

asapersson@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[tkchin_webrtc, 2016-06-03 23:55:44]

https://codereview.webrtc.org/2036773003/diff/60001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Classes/RTCMetric.mm (right):

https://codereview.webrtc.org/2036773003/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/RTCMetric.mm:24: webrtc::metrics::Enable();
Are there other metric classes that we are expecting to import? This feels like
it should just be a C function in a header somewhere if so.

eg.
RTC_EXTERN void RTCEnableMetrics();

https://codereview.webrtc.org/2036773003/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/RTCMetric.mm:27: + (NSArray<RTCMetric *>
*)getAndReset {
the "get" prefix is not used in ObjC style for object method names

This function similarly feels like it should exist as a C-func. Usually static
initializers do not have side effects, but this one does.

e.g.
RTC_EXTERN NSArray<RTCMetricsSampleInfo *> *RTCGetAndResetMetricsSamples();

https://codereview.webrtc.org/2036773003/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/RTCMetric.mm:44: -
(instancetype)initWithNativeSampleInfo:
This class sounds like the ObjC version of webrtc::metrics::SampleInfo so it
should likely be named as such.
e.g.
@interface RTCMetricsSampleInfo : NSObject
@end

https://codereview.webrtc.org/2036773003/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/RTCMetric.mm:55: NSNumber* key = [NSNumber
numberWithInt:sample.first];
this can be simplified to:
samples[@(sample.first)]  = @(sample.second)

[åsapersson, 2016-06-06 09:08:21]

Patchset #5 (id:80001) has been deleted

[åsapersson, 2016-06-06 09:25:48]

Patchset #6 (id:120001) has been deleted

[åsapersson, 2016-06-06 09:26:47]

Patchset #5 (id:100001) has been deleted

[åsapersson, 2016-06-06 09:35:42]

Patchset #6 (id:160001) has been deleted

[åsapersson, 2016-06-06 10:04:18]

Patchset #5 (id:140001) has been deleted

[åsapersson, 2016-06-06 10:57:37]

https://codereview.webrtc.org/2036773003/diff/60001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Classes/RTCMetric.mm (right):

https://codereview.webrtc.org/2036773003/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/RTCMetric.mm:24: webrtc::metrics::Enable();
On 2016/06/03 23:55:44, tkchin_webrtc wrote:
> Are there other metric classes that we are expecting to import? This feels
like
> it should just be a C function in a header somewhere if so.
> 
> eg.
> RTC_EXTERN void RTCEnableMetrics();

Done.

https://codereview.webrtc.org/2036773003/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/RTCMetric.mm:27: + (NSArray<RTCMetric *>
*)getAndReset {
On 2016/06/03 23:55:44, tkchin_webrtc wrote:
> the "get" prefix is not used in ObjC style for object method names
> 
> This function similarly feels like it should exist as a C-func. Usually static
> initializers do not have side effects, but this one does.
> 
> e.g.
> RTC_EXTERN NSArray<RTCMetricsSampleInfo *> *RTCGetAndResetMetricsSamples();

Done.

https://codereview.webrtc.org/2036773003/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/RTCMetric.mm:44: -
(instancetype)initWithNativeSampleInfo:
On 2016/06/03 23:55:44, tkchin_webrtc wrote:
> This class sounds like the ObjC version of webrtc::metrics::SampleInfo so it
> should likely be named as such.
> e.g.
> @interface RTCMetricsSampleInfo : NSObject
> @end

Moved this to a separate file RTCMetricsSampleInfo, ptal.

https://codereview.webrtc.org/2036773003/diff/60001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/RTCMetric.mm:55: NSNumber* key = [NSNumber
numberWithInt:sample.first];
On 2016/06/03 23:55:44, tkchin_webrtc wrote:
> this can be simplified to:
> mailto:samples[@(sample.first)]  = @(sample.second)

fails to compile on mac bots..

[tkchin_webrtc, 2016-06-06 17:32:51]

https://codereview.webrtc.org/2036773003/diff/180001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Classes/RTCMetrics.mm (right):

https://codereview.webrtc.org/2036773003/diff/180001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/RTCMetrics.mm:19:
NSArray<RTCMetricsSampleInfo*>* RTCGetAndResetMetrics() {
NSArray<RTCMetricsSampleInfo *> *RTCGetAndResetMetrics()

don't do git cl format, it doesn't work well for ObjC++ and even for regular
ObjC does not comply with Google style

https://codereview.webrtc.org/2036773003/diff/180001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/RTCMetrics.mm:24: NSMutableArray* metrics =
NSMutableArray *metrics

https://codereview.webrtc.org/2036773003/diff/180001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/RTCMetrics.mm:27: RTCMetricsSampleInfo* metric
= [[RTCMetricsSampleInfo alloc]
RTCMetricsSampleInfo *metric

https://codereview.webrtc.org/2036773003/diff/180001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Classes/RTCMetricsSampleInfo.mm (right):

https://codereview.webrtc.org/2036773003/diff/180001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/RTCMetricsSampleInfo.mm:33:
NSMutableDictionary* samples =
NSMutableDictionary *samples

https://codereview.webrtc.org/2036773003/diff/200001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Classes/RTCMetricsSampleInfo+Private.h (right):

https://codereview.webrtc.org/2036773003/diff/200001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/RTCMetricsSampleInfo+Private.h:21: (const
webrtc::metrics::SampleInfo&)info;
::SampleInfo &)info;

https://codereview.webrtc.org/2036773003/diff/200001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Classes/RTCMetricsSampleInfo.mm (right):

https://codereview.webrtc.org/2036773003/diff/200001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/RTCMetricsSampleInfo.mm:38: [samples
setObject:value forKey:key];
hm, I guess we haven't updated our mac deployment target.

use [samples setObject:@(sample.second) forKey:@(sample.first)] then

https://codereview.webrtc.org/2036773003/diff/200001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMetricsSampleInfo.h (right):

https://codereview.webrtc.org/2036773003/diff/200001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMetricsSampleInfo.h:30:
@property(nonatomic, readonly) NSString* name;
NSString *name

https://codereview.webrtc.org/2036773003/diff/200001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMetricsSampleInfo.h:42:
@property(nonatomic, readonly) NSDictionary<NSNumber*, NSNumber*>* samples;
NSDictionary<NSNumber *, NSNumber *> *samples;

[åsapersson, 2016-06-07 06:10:25]

https://codereview.webrtc.org/2036773003/diff/180001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Classes/RTCMetrics.mm (right):

https://codereview.webrtc.org/2036773003/diff/180001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/RTCMetrics.mm:19:
NSArray<RTCMetricsSampleInfo*>* RTCGetAndResetMetrics() {
On 2016/06/06 17:32:51, tkchin_webrtc wrote:
> NSArray<RTCMetricsSampleInfo *> *RTCGetAndResetMetrics()
> 
> don't do git cl format, it doesn't work well for ObjC++ and even for regular
> ObjC does not comply with Google style

Done.

https://codereview.webrtc.org/2036773003/diff/180001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/RTCMetrics.mm:24: NSMutableArray* metrics =
On 2016/06/06 17:32:51, tkchin_webrtc wrote:
> NSMutableArray *metrics

Done.

https://codereview.webrtc.org/2036773003/diff/180001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/RTCMetrics.mm:27: RTCMetricsSampleInfo* metric
= [[RTCMetricsSampleInfo alloc]
On 2016/06/06 17:32:51, tkchin_webrtc wrote:
> RTCMetricsSampleInfo *metric

Done.

https://codereview.webrtc.org/2036773003/diff/180001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Classes/RTCMetricsSampleInfo.mm (right):

https://codereview.webrtc.org/2036773003/diff/180001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/RTCMetricsSampleInfo.mm:33:
NSMutableDictionary* samples =
On 2016/06/06 17:32:51, tkchin_webrtc wrote:
> NSMutableDictionary *samples

Done.

https://codereview.webrtc.org/2036773003/diff/200001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Classes/RTCMetricsSampleInfo+Private.h (right):

https://codereview.webrtc.org/2036773003/diff/200001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/RTCMetricsSampleInfo+Private.h:21: (const
webrtc::metrics::SampleInfo&)info;
On 2016/06/06 17:32:51, tkchin_webrtc wrote:
> ::SampleInfo &)info;

Done.

https://codereview.webrtc.org/2036773003/diff/200001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Classes/RTCMetricsSampleInfo.mm (right):

https://codereview.webrtc.org/2036773003/diff/200001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/RTCMetricsSampleInfo.mm:38: [samples
setObject:value forKey:key];
On 2016/06/06 17:32:51, tkchin_webrtc wrote:
> hm, I guess we haven't updated our mac deployment target.
> 
> use [samples setObject:@(sample.second) forKey:@(sample.first)] then

Done.

https://codereview.webrtc.org/2036773003/diff/200001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMetricsSampleInfo.h (right):

https://codereview.webrtc.org/2036773003/diff/200001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMetricsSampleInfo.h:30:
@property(nonatomic, readonly) NSString* name;
On 2016/06/06 17:32:51, tkchin_webrtc wrote:
> NSString *name

Done.

https://codereview.webrtc.org/2036773003/diff/200001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Headers/WebRTC/RTCMetricsSampleInfo.h:42:
@property(nonatomic, readonly) NSDictionary<NSNumber*, NSNumber*>* samples;
On 2016/06/06 17:32:51, tkchin_webrtc wrote:
> NSDictionary<NSNumber *, NSNumber *> *samples;

Done.

[tkchin_webrtc, 2016-06-07 22:08:03]

lgtm

grats on first ObjC CL! Everything looked fine really, only had style nits.

https://codereview.webrtc.org/2036773003/diff/210001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Classes/RTCMetricsSampleInfo.mm (right):

https://codereview.webrtc.org/2036773003/diff/210001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/RTCMetricsSampleInfo.mm:35: for (auto const&
sample : info.samples) {
const &sample

[åsapersson, 2016-06-08 11:06:40]

https://codereview.webrtc.org/2036773003/diff/210001/webrtc/sdk/objc/Framewor...
File webrtc/sdk/objc/Framework/Classes/RTCMetricsSampleInfo.mm (right):

https://codereview.webrtc.org/2036773003/diff/210001/webrtc/sdk/objc/Framewor...
webrtc/sdk/objc/Framework/Classes/RTCMetricsSampleInfo.mm:35: for (auto const&
sample : info.samples) {
On 2016/06/07 22:08:02, tkchin_webrtc wrote:
> const &sample

Done.

[åsapersson, 2016-06-08 11:07:03]

The CQ bit was checked by asapersson@webrtc.org

[åsapersson, 2016-06-08 11:07:03]

The patchset sent to the CQ was uploaded after l-g-t-m from tkchin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2036773003/#ps250001 (title:
"rebase")

[commit-bot: I haz the power, 2016-06-08 11:07:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2036773003/250001

[commit-bot: I haz the power, 2016-06-08 11:59:19]

Description was changed from

==========
Add ObjC API for getting native histograms.

BUG=
==========

to

==========
Add ObjC API for getting native histograms.

BUG=
==========

[commit-bot: I haz the power, 2016-06-08 11:59:20]

Committed patchset #9 (id:250001)

[commit-bot: I haz the power, 2016-06-08 11:59:31]

Description was changed from

==========
Add ObjC API for getting native histograms.

BUG=
==========

to

==========
Add ObjC API for getting native histograms.

BUG=

Committed: https://crrev.com/0ab07d67cb59352235d7d2a38df2e12f7fe80865
Cr-Commit-Position: refs/heads/master@{#13064}
==========

[commit-bot: I haz the power, 2016-06-08 11:59:32]

Patchset 9 (id:??) landed as
https://crrev.com/0ab07d67cb59352235d7d2a38df2e12f7fe80865
Cr-Commit-Position: refs/heads/master@{#13064}