Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 2036123002: Add r-value constructor for RefCountedObject. (Closed)

Created:
4 years, 6 months ago by Sergey Ulanov
Modified:
4 years, 6 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add r-value constructor for RefCountedObject. Previously RefCountedObject was passing all parameters by value. This meant that it was hard to use it with movable types, such as unique_ptr<>. Now there is a constructor that takes r-value, which means that RefCountedObject<std::unique_ptr<foo>> can be initialized by passing std::unique_ptr<foo> to the constructor. Committed: https://crrev.com/f2a1c89241ef6e7c3050121ab3f5bcaca65a3375 Cr-Commit-Position: refs/heads/master@{#13079}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -64 lines) Patch
M webrtc/base/refcount.h View 4 chunks +112 lines, -63 lines 0 comments Download
M webrtc/modules/desktop_capture/shared_desktop_frame.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
Sergey Ulanov
4 years, 6 months ago (2016-06-03 09:29:05 UTC) #2
tommi
lgtm
4 years, 6 months ago (2016-06-03 11:20:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036123002/1
4 years, 6 months ago (2016-06-03 11:21:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_x64_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg/builds/4512) android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, ...
4 years, 6 months ago (2016-06-03 11:22:13 UTC) #8
Sergey Ulanov
This CL depends on https://codereview.chromium.org/1988783003/, which hasn't landed yet
4 years, 6 months ago (2016-06-03 11:23:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036123002/1
4 years, 6 months ago (2016-06-08 22:18:55 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 22:52:27 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 22:52:33 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2a1c89241ef6e7c3050121ab3f5bcaca65a3375
Cr-Commit-Position: refs/heads/master@{#13079}

Powered by Google App Engine
This is Rietveld 408576698