Reduce VT keyframe frequency.

Reduce VT keyframe frequency.

Also adds data rate limit in addition to average bitrate.

BUG=webrtc:5815
R=mflodman@webrtc.org, pbos@webrtc.org

Committed: https://crrev.com/58d4fe7be921eaf7eb1b13788f73e471d42a299e
Cr-Commit-Position: refs/heads/master@{#13017}

[tkchin_webrtc, 2016-06-02 03:25:58]

Description was changed from

==========
Reduce VT keyframe frequency.

Also adds data rate limit in addition to average bitrate.

BUG=webrtc:5815
==========

to

==========
Reduce VT keyframe frequency.

Also adds data rate limit in addition to average bitrate.

BUG=webrtc:5815
==========

[tkchin_webrtc, 2016-06-02 03:25:58]

tkchin@webrtc.org changed reviewers:
+ pbos@webrtc.org

[tkchin_webrtc, 2016-06-02 03:26:37]

Unclear what the max value can be. 240 seems to work well enough.

[mflodman, 2016-06-02 05:09:35]

mflodman@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[mflodman, 2016-06-02 05:09:35]

I think 240 is ok, we can look at changing that later.

LGTM

https://codereview.webrtc.org/2035603002/diff/1/webrtc/modules/video_coding/c...
File webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc
(right):

https://codereview.webrtc.org/2035603002/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc:473:
kVTCompressionPropertyKey_MaxKeyFrameInterval, 7200);
Good to have the same on both intervals, in case of 30 fps that is of course.

https://codereview.webrtc.org/2035603002/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.cc:519:
kVTCompressionPropertyKey_DataRateLimits,
I didn't see any good documentation around this, but this might solve a few of
the issues we've been seeing. So seems like a great change!

[pbos-webrtc, 2016-06-02 09:15:02]

lgtm

[pbos-webrtc, 2016-06-02 13:32:59]

The CQ bit was checked by pbos@webrtc.org

[commit-bot: I haz the power, 2016-06-02 13:33:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035603002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2035603002/1

[pbos-webrtc, 2016-06-02 13:36:53]

Description was changed from

==========
Reduce VT keyframe frequency.

Also adds data rate limit in addition to average bitrate.

BUG=webrtc:5815
==========

to

==========
Reduce VT keyframe frequency.

Also adds data rate limit in addition to average bitrate.

BUG=webrtc:5815
R=mflodman@webrtc.org, pbos@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/58d4fe7be921eaf7eb1b13788...
==========

[pbos-webrtc, 2016-06-02 13:36:56]

Committed patchset #1 (id:1) manually as
58d4fe7be921eaf7eb1b13788f73e471d42a299e (presubmit successful).

[commit-bot: I haz the power, 2016-06-02 13:37:00]

Description was changed from

==========
Reduce VT keyframe frequency.

Also adds data rate limit in addition to average bitrate.

BUG=webrtc:5815
R=mflodman@webrtc.org, pbos@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/58d4fe7be921eaf7eb1b13788...
==========

to

==========
Reduce VT keyframe frequency.

Also adds data rate limit in addition to average bitrate.

BUG=webrtc:5815
R=mflodman@webrtc.org, pbos@webrtc.org

Committed: https://crrev.com/58d4fe7be921eaf7eb1b13788f73e471d42a299e
Cr-Commit-Position: refs/heads/master@{#13017}
==========