Hibernate the thread if there are no events in the queue. Wake it up when an event is added to the …

webrtc/call/rtc_event_log_helper_thread.h

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 50 matching lines @@
       swap(lhs.max_size_bytes, rhs.max_size_bytes);
       swap(lhs.start_time, rhs.start_time);
       swap(lhs.stop_time, rhs.stop_time);
     }
   };
 
   RtcEventLogHelperThread(
       SwapQueue<ControlMessage>* message_queue,
       SwapQueue<std::unique_ptr<rtclog::Event>>* event_queue,
       rtc::Event* wake_up,
+      rtc::Event* end_hibernation,
       rtc::Event* file_finished,
       const Clock* const clock);
   ~RtcEventLogHelperThread();
 
  private:
   static bool ThreadOutputFunction(void* obj);
 
-  void TerminateThread();
   bool AppendEventToString(rtclog::Event* event);
-  void AppendEventToHistory(const rtclog::Event& event);
-  void LogToMemory();
+  int LogToMemory();

[pbos-webrtc, 2016/06/03 08:56:15]

size_t or preferably just a bool for whether it succeeds or not.

[terelius, 2016/06/08 11:47:29]

Changed to bool.

   void StartLogFile();
-  void LogToFile();
+  int LogToFile();
   void StopLogFile();
-  void WriteLog();
+  void ProcessEvents();
 
   // Message queues for passing events to the logging thread.
   SwapQueue<ControlMessage>* message_queue_;
   SwapQueue<std::unique_ptr<rtclog::Event>>* event_queue_;
 
   // History containing the most recent events (~ 10 s).
   RingBuffer<std::unique_ptr<rtclog::Event>> history_;
 
   // History containing all past configuration events.
   std::vector<std::unique_ptr<rtclog::Event>> config_history_;
 
   std::unique_ptr<FileWrapper> file_;
   rtc::PlatformThread thread_;
 
   int64_t max_size_bytes_;
   int64_t written_bytes_;
   int64_t start_time_;
   int64_t stop_time_;
 
   bool has_recent_event_;
   std::unique_ptr<rtclog::Event> most_recent_event_;
 
   // Temporary space for serializing profobuf data.
   std::string output_string_;
 
   rtc::Event* wake_up_;
+  rtc::Event* end_hibernation_;

[pbos-webrtc, 2016/06/03 08:51:06]

Shouldn't the wake_up_ event be sufficient to signal that we should wake up? Or
is the wake_up_ event really just a timer that can be awoken in the destructor?
If this is the case then wake_up_ should preferably be renamed something like
batch_timer_ or something.

[terelius, 2016/06/08 11:47:29]

Both are needed. I renamed them wake_periodically_ and wake_from_hibernation_.

   rtc::Event* stopped_;
 
   const Clock* const clock_;
 
   RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(RtcEventLogHelperThread);
 };
 
 }  // namespace webrtc
 
 #endif  // ENABLE_RTC_EVENT_LOG
 
 #endif  // WEBRTC_CALL_RTC_EVENT_LOG_HELPER_THREAD_H_