Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Side by Side Diff: webrtc/common_video/video_render_frames.h

Issue 2035173002: Split IncomingVideoStream into two implementations, with smoothing and without. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase again Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_COMMON_VIDEO_VIDEO_RENDER_FRAMES_H_ 11 #ifndef WEBRTC_COMMON_VIDEO_VIDEO_RENDER_FRAMES_H_
12 #define WEBRTC_COMMON_VIDEO_VIDEO_RENDER_FRAMES_H_ 12 #define WEBRTC_COMMON_VIDEO_VIDEO_RENDER_FRAMES_H_
13 13
14 #include <stdint.h> 14 #include <stdint.h>
15 15
16 #include <list> 16 #include <list>
17 17
18 #include "webrtc/base/optional.h" 18 #include "webrtc/base/optional.h"
19 #include "webrtc/video_frame.h" 19 #include "webrtc/video_frame.h"
20 20
21 namespace webrtc { 21 namespace webrtc {
22 22
23 // Class definitions 23 // Class definitions
24 class VideoRenderFrames { 24 class VideoRenderFrames {
25 public: 25 public:
26 VideoRenderFrames(); 26 explicit VideoRenderFrames(uint32_t render_delay_ms);
27 VideoRenderFrames(const VideoRenderFrames&) = delete;
27 28
28 // Add a frame to the render queue 29 // Add a frame to the render queue
29 int32_t AddFrame(const VideoFrame& new_frame); 30 int32_t AddFrame(const VideoFrame& new_frame);
30 31
31 // Get a frame for rendering, or false if it's not time to render. 32 // Get a frame for rendering, or false if it's not time to render.
32 rtc::Optional<VideoFrame> FrameToRender(); 33 rtc::Optional<VideoFrame> FrameToRender();
33 34
34 // Releases all frames 35 // Releases all frames
35 int32_t ReleaseAllFrames(); 36 int32_t ReleaseAllFrames();
mflodman 2016/06/13 18:39:24 We can remove this method.
tommi 2016/06/14 08:11:27 Done.
mflodman 2016/06/14 08:59:25 Thanks!
36 37
37 // Returns the number of ms to next frame to render 38 // Returns the number of ms to next frame to render
38 uint32_t TimeToNextFrameRelease(); 39 uint32_t TimeToNextFrameRelease();
39 40
40 // Sets estimates delay in renderer
41 int32_t SetRenderDelay(const uint32_t render_delay);
42
43 private: 41 private:
44 // 10 seconds for 30 fps. 42 // 10 seconds for 30 fps.
45 enum { KMaxNumberOfFrames = 300 }; 43 enum { KMaxNumberOfFrames = 300 };
46 // Don't render frames with timestamp older than 500ms from now. 44 // Don't render frames with timestamp older than 500ms from now.
47 enum { KOldRenderTimestampMS = 500 }; 45 enum { KOldRenderTimestampMS = 500 };
48 // Don't render frames with timestamp more than 10s into the future. 46 // Don't render frames with timestamp more than 10s into the future.
49 enum { KFutureRenderTimestampMS = 10000 }; 47 enum { KFutureRenderTimestampMS = 10000 };
50 48
51 // Sorted list with framed to be rendered, oldest first. 49 // Sorted list with framed to be rendered, oldest first.
52 std::list<VideoFrame> incoming_frames_; 50 std::list<VideoFrame> incoming_frames_;
53 51
54 // Estimated delay from a frame is released until it's rendered. 52 // Estimated delay from a frame is released until it's rendered.
55 uint32_t render_delay_ms_; 53 const uint32_t render_delay_ms_;
56 }; 54 };
57 55
58 } // namespace webrtc 56 } // namespace webrtc
59 57
60 #endif // WEBRTC_COMMON_VIDEO_VIDEO_RENDER_FRAMES_H_ 58 #endif // WEBRTC_COMMON_VIDEO_VIDEO_RENDER_FRAMES_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698