Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2034033002:
Fix stats hud in AppRTC Demo for iOS. (Closed)
|
Created:
4 years, 6 months ago by stefan-webrtc Modified:
4 years, 5 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFix stats hud in AppRTC Demo for iOS.
NOTRY=true
Committed: https://crrev.com/ff4def7eb7a747591bf31a724e967064e27b5d63
Cr-Commit-Position: refs/heads/master@{#13290}
Patch Set 1 #Patch Set 2 : Clean #
Total comments: 4
Patch Set 3 : Comments. #Messages
Total messages: 30 (12 generated)
Clean
stefan@webrtc.org changed reviewers: + pbos@webrtc.org, perkj@webrtc.org
https://codereview.webrtc.org/2034033002/diff/20001/webrtc/examples/objc/AppR... File webrtc/examples/objc/AppRTCDemo/ARDStatsBuilder.m (right): https://codereview.webrtc.org/2034033002/diff/20001/webrtc/examples/objc/AppR... webrtc/examples/objc/AppRTCDemo/ARDStatsBuilder.m:250: if (values[@"googFrameWidthReceived"]) { Do objectForKey here as well. https://codereview.webrtc.org/2034033002/diff/20001/webrtc/examples/objc/AppR... webrtc/examples/objc/AppRTCDemo/ARDStatsBuilder.m:251: [self parseVideoRecvStatsReport:statsReport]; Add // Video track. and Audio below to unify with parseSendSsrcStatsReport
Comments.
https://codereview.webrtc.org/2034033002/diff/20001/webrtc/examples/objc/AppR... File webrtc/examples/objc/AppRTCDemo/ARDStatsBuilder.m (right): https://codereview.webrtc.org/2034033002/diff/20001/webrtc/examples/objc/AppR... webrtc/examples/objc/AppRTCDemo/ARDStatsBuilder.m:250: if (values[@"googFrameWidthReceived"]) { On 2016/06/03 10:05:24, pbos-webrtc wrote: > Do objectForKey here as well. Done. https://codereview.webrtc.org/2034033002/diff/20001/webrtc/examples/objc/AppR... webrtc/examples/objc/AppRTCDemo/ARDStatsBuilder.m:251: [self parseVideoRecvStatsReport:statsReport]; On 2016/06/03 10:05:24, pbos-webrtc wrote: > Add // Video track. and Audio below to unify with parseSendSsrcStatsReport Done.
lgtm
rs lgtm
On 2016/06/03 13:42:58, perkj_webrtc wrote: > rs lgtm Do not use objectForKey, used indexed subscript. Subscript is syntactic sugar for objectForKey.
tkchin@webrtc.org changed reviewers: + tkchin@webrtc.org
On 2016/06/03 17:56:53, tkchin_webrtc wrote: > On 2016/06/03 13:42:58, perkj_webrtc wrote: > > rs lgtm > > Do not use objectForKey, used indexed subscript. Subscript is syntactic sugar > for objectForKey. Actually forgot that our Mac target deployment is 10.7 and it won't work on that. Committing for you.
The CQ bit was checked by tkchin@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)
The CQ bit was checked by pbos@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_asan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/15712)
The CQ bit was checked by pbos@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14473)
Description was changed from ========== Fix stats hud in AppRTC Demo for iOS. ========== to ========== Fix stats hud in AppRTC Demo for iOS. NOTRY=true ==========
The CQ bit was checked by pbos@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Fix stats hud in AppRTC Demo for iOS. NOTRY=true ========== to ========== Fix stats hud in AppRTC Demo for iOS. NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fix stats hud in AppRTC Demo for iOS. NOTRY=true ========== to ========== Fix stats hud in AppRTC Demo for iOS. NOTRY=true Committed: https://crrev.com/ff4def7eb7a747591bf31a724e967064e27b5d63 Cr-Commit-Position: refs/heads/master@{#13290} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/ff4def7eb7a747591bf31a724e967064e27b5d63 Cr-Commit-Position: refs/heads/master@{#13290} |
