Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2034013003: Remove DtlsIdentityStoreInterface, it is no longer used. (Closed)

Created:
4 years, 6 months ago by hbos
Modified:
4 years, 5 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove DtlsIdentityStoreInterface, it is no longer used. This interface and its implementations have been replaced by rtc::RTCCertificateGeneratorInterface. Removes dtlsidentitystore.h, updates .gyp/gn and removes old #includes. BUG=webrtc:5707, webrtc:5708 Committed: https://crrev.com/3d70fef3f36b2bd39957c769adbbce96e638ae9e Cr-Commit-Position: refs/heads/master@{#13432}

Patch Set 1 : #

Patch Set 2 : Rebase with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -73 lines) Patch
M webrtc/api/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/android/jni/peerconnection_jni.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/api.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/api/dtlsidentitystore.h View 1 chunk +0 lines, -66 lines 0 comments Download
M webrtc/api/peerconnectionfactory_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/test/fakertccertificategenerator.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/webrtcsession_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/webrtcsessiondescriptionfactory.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
hbos
Please take a look, tommi. Note: I will hold of landing this until a chromium ...
4 years, 6 months ago (2016-06-09 13:57:06 UTC) #7
tommi
lgtm
4 years, 6 months ago (2016-06-09 14:08:51 UTC) #8
hbos
Note to self: Also need to remove https://cs.chromium.org/chromium/src/third_party/libjingle/libjingle.gyp?q=libjingle.gyp+dtlsidentitystore.h&sq=package:chromium&l=225&dr=C and corresponding BUILD.gn before landing this as ...
4 years, 6 months ago (2016-06-10 10:13:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2034013003/80001
4 years, 5 months ago (2016-07-11 09:04:20 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 5 months ago (2016-07-11 11:10:14 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 11:10:16 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 11:10:20 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3d70fef3f36b2bd39957c769adbbce96e638ae9e
Cr-Commit-Position: refs/heads/master@{#13432}

Powered by Google App Engine
This is Rietveld 408576698