Add enum value ScaleMethod::kFilterLinear.

Add enum value ScaleMethod::kFilterLinear.

Needed to get the same numerical values as used in libyuv.

BUG=
R=ossu@webrtc.org, pbos@webrtc.org

Committed: https://crrev.com/e80990f20f51e612b185ecc888d5a30e6a597405
Cr-Commit-Position: refs/heads/master@{#13035}

[nisse-webrtc, 2016-06-03 11:47:11]

nisse@webrtc.org changed reviewers:
+ pbos@webrtc.org

[nisse-webrtc, 2016-06-03 11:47:11]

This is the "one-line" fix. I haven't yet tested if it has the desired effect,
but I think it's quite safe.

Better solutions are possible, of course, but I have a pending cl deleting all
of the webrtc::Scaler class, so I'd like to keep this as simple as possible.

[ossu, 2016-06-03 11:50:32]

ossu@webrtc.org changed reviewers:
+ ossu@webrtc.org

[ossu, 2016-06-03 11:50:32]

https://codereview.webrtc.org/2033143003/diff/1/webrtc/common_video/libyuv/in...
File webrtc/common_video/libyuv/include/scaler.h (right):

https://codereview.webrtc.org/2033143003/diff/1/webrtc/common_video/libyuv/in...
webrtc/common_video/libyuv/include/scaler.h:26: // Note: Must have the same
values as libyuv::FilterMode.
So, the problem was it picked the wrong scaling mode due to a mismatch of enums?
Sounds like a dangerous practice. Why isn't ScaleMethod an alias for
libyuv::FilterMode if they need to be the same?

[nisse-webrtc, 2016-06-03 11:54:54]

https://codereview.webrtc.org/2033143003/diff/1/webrtc/common_video/libyuv/in...
File webrtc/common_video/libyuv/include/scaler.h (right):

https://codereview.webrtc.org/2033143003/diff/1/webrtc/common_video/libyuv/in...
webrtc/common_video/libyuv/include/scaler.h:26: // Note: Must have the same
values as libyuv::FilterMode.
On 2016/06/03 11:50:32, ossu wrote:
> So, the problem was it picked the wrong scaling mode due to a mismatch of
enums?

That's my understanding, yes.

> Why isn't ScaleMethod an alias for
> libyuv::FilterMode if they need to be the same?

Good question. I would have done that, if it wasn't for my plan to delete this
code very soon (cl https://codereview.webrtc.org/2020593002/).

[nisse-webrtc, 2016-06-03 11:57:11]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-03 11:57:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2033143003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2033143003/1

[ossu, 2016-06-03 12:37:15]

https://codereview.webrtc.org/2033143003/diff/1/webrtc/common_video/libyuv/in...
File webrtc/common_video/libyuv/include/scaler.h (right):

https://codereview.webrtc.org/2033143003/diff/1/webrtc/common_video/libyuv/in...
webrtc/common_video/libyuv/include/scaler.h:26: // Note: Must have the same
values as libyuv::FilterMode.
Ah! Then this one-liner really seems like the prudent choice.

[ossu, 2016-06-03 12:59:56]

lgtm

[pbos-webrtc, 2016-06-03 13:20:08]

eew, lgtm

[nisse-webrtc, 2016-06-03 13:45:18]

Description was changed from

==========
Add enum value ScaleMethod::kFilterLinear.

Needed to get the same numerical values as used in libyuv.

BUG=
==========

to

==========
Add enum value ScaleMethod::kFilterLinear.

Needed to get the same numerical values as used in libyuv.

BUG=
R=ossu@webrtc.org, pbos@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/e80990f20f51e612b185ecc88...
==========

[nisse-webrtc, 2016-06-03 13:45:20]

Committed patchset #1 (id:1) manually as
e80990f20f51e612b185ecc888d5a30e6a597405 (presubmit successful).

[commit-bot: I haz the power, 2016-06-03 14:19:01]

Description was changed from

==========
Add enum value ScaleMethod::kFilterLinear.

Needed to get the same numerical values as used in libyuv.

BUG=
R=ossu@webrtc.org, pbos@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/e80990f20f51e612b185ecc88...
==========

to

==========
Add enum value ScaleMethod::kFilterLinear.

Needed to get the same numerical values as used in libyuv.

BUG=
R=ossu@webrtc.org, pbos@webrtc.org

Committed: https://crrev.com/e80990f20f51e612b185ecc888d5a30e6a597405
Cr-Commit-Position: refs/heads/master@{#13035}
==========