Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2033073002: BitrateProber now correctly change state to kWait when the last probing (Closed)

Created:
4 years, 6 months ago by philipel
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

BitrateProber now correctly change state to kWait when the last probing cluster has been spent. BUG=webrtc:5859 Committed: https://crrev.com/1a93cdeabe896cf8d2c34609e0e9781a37894368 Cr-Commit-Position: refs/heads/master@{#13027}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M webrtc/modules/pacing/bitrate_prober.cc View 1 chunk +2 lines, -0 lines 1 comment Download
M webrtc/modules/pacing/paced_sender.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M webrtc/modules/pacing/paced_sender_unittest.cc View 2 chunks +11 lines, -4 lines 1 comment Download

Messages

Total messages: 21 (10 generated)
philipel
4 years, 6 months ago (2016-06-02 13:27:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033073002/1
4 years, 6 months ago (2016-06-02 14:08:12 UTC) #5
danilchap
lgtm https://codereview.webrtc.org/2033073002/diff/1/webrtc/modules/pacing/paced_sender_unittest.cc File webrtc/modules/pacing/paced_sender_unittest.cc (right): https://codereview.webrtc.org/2033073002/diff/1/webrtc/modules/pacing/paced_sender_unittest.cc#newcode877 webrtc/modules/pacing/paced_sender_unittest.cc:877: May be add constants kPacketsPerProbe = 5; kPacketsPerFirstProbe ...
4 years, 6 months ago (2016-06-02 14:28:05 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-02 15:22:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033073002/1
4 years, 6 months ago (2016-06-02 15:52:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6041)
4 years, 6 months ago (2016-06-02 15:55:04 UTC) #12
philipel
Need owners approval, Stefan PTAL.
4 years, 6 months ago (2016-06-02 15:57:19 UTC) #14
stefan-webrtc
lgtm https://codereview.webrtc.org/2033073002/diff/1/webrtc/modules/pacing/bitrate_prober.cc File webrtc/modules/pacing/bitrate_prober.cc (right): https://codereview.webrtc.org/2033073002/diff/1/webrtc/modules/pacing/bitrate_prober.cc#newcode125 webrtc/modules/pacing/bitrate_prober.cc:125: // kWait if we later want to probe ...
4 years, 6 months ago (2016-06-02 15:58:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2033073002/1
4 years, 6 months ago (2016-06-03 08:40:12 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 08:41:48 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 08:41:56 UTC) #21
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1a93cdeabe896cf8d2c34609e0e9781a37894368
Cr-Commit-Position: refs/heads/master@{#13027}

Powered by Google App Engine
This is Rietveld 408576698