Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2032473002: Revert "Revert of Propagate probing cluster id to SendTimeHistory. (patchset #5 id:80001 of https:/… (Closed)

Created:
4 years, 6 months ago by philipel
Modified:
4 years, 6 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, danilchap, zhuangzesen_agora.io, Andrew MacDonald, henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert "Revert of Propagate probing cluster id to SendTimeHistory. (patchset #5 id:80001 of https://codereview.webrtc.org/2005313003/ )" This reverts commit 46948c17fd09e4957bebc8ea61f0a8e77ff84b48. TBR=mflodman@webrtc.org BUG=webrtc:5859 Committed: https://crrev.com/a1ed0b3241230c56eec0420467f4a62e9f2fb6d6 Cr-Commit-Position: refs/heads/master@{#12992}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -190 lines) Patch
M webrtc/modules/pacing/paced_sender.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M webrtc/modules/pacing/paced_sender_unittest.cc View 13 chunks +19 lines, -19 lines 0 comments Download
M webrtc/modules/pacing/packet_router.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/pacing/packet_router.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M webrtc/modules/pacing/packet_router_unittest.cc View 5 chunks +35 lines, -30 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/include/send_time_history.h View 1 chunk +4 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/send_time_history.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc View 8 chunks +62 lines, -39 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/packet_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/packet_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc View 6 chunks +23 lines, -19 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_rtcp.h View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h View 3 chunks +21 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h View 1 chunk +7 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 3 chunks +14 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 10 chunks +30 lines, -17 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 13 chunks +23 lines, -15 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
philipel
4 years, 6 months ago (2016-06-01 11:29:06 UTC) #2
stefan-webrtc
lgtm
4 years, 6 months ago (2016-06-01 11:36:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032473002/1
4 years, 6 months ago (2016-06-01 11:36:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 13:31:22 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 13:31:28 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a1ed0b3241230c56eec0420467f4a62e9f2fb6d6
Cr-Commit-Position: refs/heads/master@{#12992}

Powered by Google App Engine
This is Rietveld 408576698