Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_sender.cc

Issue 2032463003: Revert of Propagate probing cluster id to SendTimeHistory. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_sender.h ('k') | webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtp_sender.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender.cc b/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
index 3ad2293c860bf24ac8cb292e044581591b82907b..cda776bf22b2cdcef3510233fe94acda11286aa4 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtp_sender.cc
@@ -543,8 +543,7 @@
return ret_val;
}
-size_t RTPSender::TrySendRedundantPayloads(size_t bytes_to_send,
- int probe_cluster_id) {
+size_t RTPSender::TrySendRedundantPayloads(size_t bytes_to_send) {
{
rtc::CritScope lock(&send_critsect_);
if (!sending_media_)
@@ -562,8 +561,7 @@
&capture_time_ms)) {
break;
}
- if (!PrepareAndSendPacket(buffer, length, capture_time_ms, true, false,
- probe_cluster_id))
+ if (!PrepareAndSendPacket(buffer, length, capture_time_ms, true, false))
break;
RtpUtility::RtpHeaderParser rtp_parser(buffer, length);
RTPHeader rtp_header;
@@ -591,8 +589,7 @@
size_t RTPSender::SendPadData(size_t bytes,
bool timestamp_provided,
uint32_t timestamp,
- int64_t capture_time_ms,
- int probe_cluster_id) {
+ int64_t capture_time_ms) {
// Always send full padding packets. This is accounted for by the
// RtpPacketSender,
// which will make sure we don't send too much padding even if a single packet
@@ -680,7 +677,7 @@
length, rtp_header)) {
if (transport_feedback_observer_)
transport_feedback_observer_->AddPacket(options.packet_id, length,
- true, probe_cluster_id);
+ true);
}
}
@@ -736,8 +733,7 @@
rtx = rtx_;
}
if (!PrepareAndSendPacket(data_buffer, length, capture_time_ms,
- (rtx & kRtxRetransmitted) > 0, true,
- PacketInfo::kNotAProbe)) {
+ (rtx & kRtxRetransmitted) > 0, true)) {
return -1;
}
return static_cast<int32_t>(length);
@@ -873,8 +869,7 @@
// Called from pacer when we can send the packet.
bool RTPSender::TimeToSendPacket(uint16_t sequence_number,
int64_t capture_time_ms,
- bool retransmission,
- int probe_cluster_id) {
+ bool retransmission) {
size_t length = IP_PACKET_SIZE;
uint8_t data_buffer[IP_PACKET_SIZE];
int64_t stored_time_ms;
@@ -894,17 +889,18 @@
rtc::CritScope lock(&send_critsect_);
rtx = rtx_;
}
- return PrepareAndSendPacket(data_buffer, length, capture_time_ms,
+ return PrepareAndSendPacket(data_buffer,
+ length,
+ capture_time_ms,
retransmission && (rtx & kRtxRetransmitted) > 0,
- retransmission, probe_cluster_id);
+ retransmission);
}
bool RTPSender::PrepareAndSendPacket(uint8_t* buffer,
size_t length,
int64_t capture_time_ms,
bool send_over_rtx,
- bool is_retransmit,
- int probe_cluster_id) {
+ bool is_retransmit) {
uint8_t* buffer_to_send_ptr = buffer;
RtpUtility::RtpHeaderParser rtp_parser(buffer, length);
@@ -936,8 +932,8 @@
if (UpdateTransportSequenceNumber(options.packet_id, buffer_to_send_ptr,
length, rtp_header)) {
if (transport_feedback_observer_)
- transport_feedback_observer_->AddPacket(options.packet_id, length, true,
- probe_cluster_id);
+ transport_feedback_observer_->AddPacket(options.packet_id, length,
+ true);
}
}
@@ -1004,13 +1000,12 @@
buffer[header.headerLength] == pt_fec;
}
-size_t RTPSender::TimeToSendPadding(size_t bytes, int probe_cluster_id) {
+size_t RTPSender::TimeToSendPadding(size_t bytes) {
if (audio_configured_ || bytes == 0)
return 0;
- size_t bytes_sent = TrySendRedundantPayloads(bytes, probe_cluster_id);
+ size_t bytes_sent = TrySendRedundantPayloads(bytes);
if (bytes_sent < bytes)
- bytes_sent +=
- SendPadData(bytes - bytes_sent, false, 0, 0, probe_cluster_id);
+ bytes_sent += SendPadData(bytes - bytes_sent, false, 0, 0);
return bytes_sent;
}
@@ -1067,8 +1062,8 @@
if (UpdateTransportSequenceNumber(options.packet_id, buffer, length,
rtp_header)) {
if (transport_feedback_observer_)
- transport_feedback_observer_->AddPacket(options.packet_id, length, true,
- PacketInfo::kNotAProbe);
+ transport_feedback_observer_->AddPacket(options.packet_id, length,
+ true);
}
}
UpdateDelayStatistics(capture_time_ms, now_ms);
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_sender.h ('k') | webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698