Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2032463003: Revert of Propagate probing cluster id to SendTimeHistory. (Closed)

Created:
4 years, 6 months ago by philipel
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, danilchap, zhuangzesen_agora.io, Andrew MacDonald, henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Propagate probing cluster id to SendTimeHistory. (patchset #5 id:80001 of https://codereview.webrtc.org/2005313003/ ) Reason for revert: Breaks google3 buildbot: http://webrtc-buildbot-master.mtv.corp.google.com:21000/builders/WebRTC%20google3%20Importer/builds/8640 Original issue's description: > Propagate probing cluster id to SendTimeHistory, both for packets and padding. > > BUG=webrtc:5859 > > Committed: https://crrev.com/5be28c848b91bc6e4800eac07a3f5ac09a32ad70 > Cr-Commit-Position: refs/heads/master@{#12985} TBR=danilchap@webrtc.org,stefan@webrtc.org,mflodman@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5859 Committed: https://crrev.com/46948c17fd09e4957bebc8ea61f0a8e77ff84b48 Cr-Commit-Position: refs/heads/master@{#12987}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -283 lines) Patch
M webrtc/modules/pacing/paced_sender.h View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M webrtc/modules/pacing/paced_sender_unittest.cc View 13 chunks +19 lines, -19 lines 0 comments Download
M webrtc/modules/pacing/packet_router.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/pacing/packet_router.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M webrtc/modules/pacing/packet_router_unittest.cc View 5 chunks +31 lines, -36 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/include/send_time_history.h View 1 chunk +1 line, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/send_time_history.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc View 8 chunks +41 lines, -64 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/packet_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/packet_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter_unittest.cc View 6 chunks +19 lines, -23 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_rtcp.h View 1 chunk +3 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h View 3 chunks +6 lines, -21 lines 0 comments Download
M webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h View 1 chunk +5 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 3 chunks +6 lines, -10 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 10 chunks +18 lines, -23 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 13 chunks +15 lines, -23 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipel
Created Revert of Propagate probing cluster id to SendTimeHistory.
4 years, 6 months ago (2016-06-01 11:04:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032463003/1
4 years, 6 months ago (2016-06-01 11:04:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 11:04:45 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 11:04:58 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/46948c17fd09e4957bebc8ea61f0a8e77ff84b48
Cr-Commit-Position: refs/heads/master@{#12987}

Powered by Google App Engine
This is Rietveld 408576698