Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

Issue 2030903002: Reduce logging frequency in bwe simulations. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc
diff --git a/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc b/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc
index 3cf7c752a07e911bd680a3c48e0addaf57518ecb..b1e42ac02a25a52c79e2f64525980ca1155eccc3 100644
--- a/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc
+++ b/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc
@@ -28,7 +28,8 @@ FullBweSender::FullBweSender(int kbps, BitrateObserver* observer, Clock* clock)
clock_(clock),
send_time_history_(clock_, 10000),
has_received_ack_(false),
- last_acked_seq_num_(0) {
+ last_acked_seq_num_(0),
+ last_log_time_ms_(0) {
assert(kbps >= kMinBitrateKbps);
assert(kbps <= kMaxBitrateKbps);
bitrate_controller_->SetStartBitrate(1000 * kbps);
@@ -52,7 +53,11 @@ void FullBweSender::GiveFeedback(const FeedbackPacket& feedback) {
std::vector<PacketInfo> packet_feedback_vector(fb.packet_feedback_vector());
for (PacketInfo& packet_info : packet_feedback_vector) {
if (!send_time_history_.GetInfo(&packet_info, true)) {
- LOG(LS_WARNING) << "Ack arrived too late.";
+ int64_t now_ms = clock_->TimeInMilliseconds();
+ if (now_ms - last_log_time_ms_ > 5000) {
+ LOG(LS_WARNING) << "Ack arrived too late.";
+ last_log_time_ms_ = now_ms;
+ }
}
}
« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698