Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2030823004: Fix building iOS SDK static libraries. (Closed)

Created:
4 years, 6 months ago by tkchin_webrtc
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix building iOS SDK static libraries. NOTRY=True Committed: https://crrev.com/2bd81a8a00950622b53b9b146945d95add0b3602 Cr-Commit-Position: refs/heads/master@{#13020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/build/ios/objc_app.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
tkchin_webrtc
4 years, 6 months ago (2016-06-02 18:17:23 UTC) #3
kjellander_webrtc
Oh, I guess I broke this with https://codereview.webrtc.org/2026223002/ Can/should we add another bot config to ...
4 years, 6 months ago (2016-06-02 18:34:46 UTC) #4
kjellander_webrtc
On 2016/06/02 18:34:46, kjellander_webrtc wrote: > Oh, I guess I broke this with https://codereview.webrtc.org/2026223002/ > ...
4 years, 6 months ago (2016-06-02 18:35:49 UTC) #6
tkchin_webrtc
On 2016/06/02 18:35:49, kjellander_webrtc wrote: > On 2016/06/02 18:34:46, kjellander_webrtc wrote: > > Oh, I ...
4 years, 6 months ago (2016-06-02 19:15:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030823004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030823004/1
4 years, 6 months ago (2016-06-02 19:16:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 19:22:20 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 19:22:31 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2bd81a8a00950622b53b9b146945d95add0b3602
Cr-Commit-Position: refs/heads/master@{#13020}

Powered by Google App Engine
This is Rietveld 408576698