Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2030283002: Revert of Update the BWE when the network route changes. (Closed)

Created:
4 years, 6 months ago by guidou
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, zhuangzesen_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, pbos-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Update the BWE when the network route changes. (patchset #5 id:180001 of https://codereview.webrtc.org/2000063003/ ) Reason for revert: Speculative revert due to failure in Mac Tester FYI bot. See https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Tester/builds/30642 Will reland if the revert doesn't fix the bot. Original issue's description: > Update the BWE when the network route changes. > > BUG= > > Committed: https://crrev.com/2221e1cd1dd19ae16c87c14bbea92fa62d15154d > Cr-Commit-Position: refs/heads/master@{#13021} TBR=stefan@webrtc.org,pthatcher@webrtc.org,honghaiz@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/72d41aa6da94dacb8a8464d1abd4ca7d1afffc65 Cr-Commit-Position: refs/heads/master@{#13023}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -87 lines) Patch
M webrtc/call/call.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M webrtc/modules/bitrate_controller/include/bitrate_controller.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/bitrate_controller/include/mock/mock_bitrate_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 3 chunks +12 lines, -39 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller_unittest.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M webrtc/modules/congestion_controller/include/congestion_controller.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
guidou
Created Revert of Update the BWE when the network route changes.
4 years, 6 months ago (2016-06-03 06:24:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030283002/1
4 years, 6 months ago (2016-06-03 06:24:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 06:24:56 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 06:25:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72d41aa6da94dacb8a8464d1abd4ca7d1afffc65
Cr-Commit-Position: refs/heads/master@{#13023}

Powered by Google App Engine
This is Rietveld 408576698