Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2030073002: Collapse most spammy output of webrtc_perf_tests with PrintResultList (Closed)

Created:
4 years, 6 months ago by danilchap
Modified:
4 years, 6 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, pbos-webrtc, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Collapse most stdout spammy output of webrtc_perf_tests with PrintResultList BUG=webrtc:5032 NOTRY=true Committed: https://crrev.com/46b89b9a3f3f92acea250ab9e34a479040101145 Cr-Commit-Position: refs/heads/master@{#13037}

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -21 lines) Patch
M webrtc/call/call_perf_tests.cc View 1 9 chunks +22 lines, -21 lines 0 comments Download
M webrtc/test/testsupport/perf_test.h View 1 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
danilchap
4 years, 6 months ago (2016-06-02 16:46:19 UTC) #3
pbos-webrtc
lgtm with code moved https://codereview.webrtc.org/2030073002/diff/1/webrtc/call/call_perf_tests.cc File webrtc/call/call_perf_tests.cc (right): https://codereview.webrtc.org/2030073002/diff/1/webrtc/call/call_perf_tests.cc#newcode54 webrtc/call/call_perf_tests.cc:54: // Converts list of values ...
4 years, 6 months ago (2016-06-03 15:10:03 UTC) #4
danilchap
https://codereview.webrtc.org/2030073002/diff/1/webrtc/call/call_perf_tests.cc File webrtc/call/call_perf_tests.cc (right): https://codereview.webrtc.org/2030073002/diff/1/webrtc/call/call_perf_tests.cc#newcode54 webrtc/call/call_perf_tests.cc:54: // Converts list of values into comma-separated string for ...
4 years, 6 months ago (2016-06-03 15:32:13 UTC) #5
pbos-webrtc
lgtm
4 years, 6 months ago (2016-06-03 15:33:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030073002/20001
4 years, 6 months ago (2016-06-03 16:26:02 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-03 16:27:42 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 16:27:53 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/46b89b9a3f3f92acea250ab9e34a479040101145
Cr-Commit-Position: refs/heads/master@{#13037}

Powered by Google App Engine
This is Rietveld 408576698