Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2029853002: Fixing flaky SignalThread tests. (Closed)

Created:
4 years, 6 months ago by Taylor Brandstetter
Modified:
4 years, 6 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing flaky SignalThread tests. Using an "EXPECT_WAIT" pattern with a long timeout rather than calling "SleepMs" with a margin of 250ms. BUG=webrtc:5953 Committed: https://crrev.com/d50f4f331e8cc2a88f51db083975fceb76448e83 Cr-Commit-Position: refs/heads/master@{#13040}

Patch Set 1 #

Patch Set 2 : Merge with master, un-disable flaky tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -24 lines) Patch
M webrtc/base/signalthread_unittest.cc View 1 3 chunks +15 lines, -24 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Taylor Brandstetter
4 years, 6 months ago (2016-06-01 23:10:07 UTC) #2
pthatcher1
lgtm
4 years, 6 months ago (2016-06-03 00:30:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029853002/20001
4 years, 6 months ago (2016-06-03 15:43:52 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-03 17:31:03 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 17:31:12 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d50f4f331e8cc2a88f51db083975fceb76448e83
Cr-Commit-Position: refs/heads/master@{#13040}

Powered by Google App Engine
This is Rietveld 408576698