webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h - Issue 2029593002: Update RateStatistics to handle too-little-data case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h

Issue 2029593002: Update RateStatistics to handle too-little-data case. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Addressed comment Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/aimd_rate_control.cc ('k') | webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h

diff --git a/webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h b/webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h

index 3fb7e29e5b2fac5a1232c4bb78fd0cec7c4517f6..9aa82cff976ad1070d5ad3d178c6a9ea7bed59e6 100644

--- a/webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h

+++ b/webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h

@@ -11,6 +11,7 @@

#ifndef WEBRTC_MODULES_REMOTE_BITRATE_ESTIMATOR_INCLUDE_BWE_DEFINES_H_

#define WEBRTC_MODULES_REMOTE_BITRATE_ESTIMATOR_INCLUDE_BWE_DEFINES_H_

+#include "webrtc/base/optional.h"

#include "webrtc/typedefs.h"

#define BWE_MAX(a, b) ((a) > (b) ? (a) : (b))

@@ -32,14 +33,14 @@ enum RateControlRegion { kRcNearMax, kRcAboveMax, kRcMaxUnknown };

struct RateControlInput {

RateControlInput(BandwidthUsage bw_state,

- uint32_t incoming_bitrate,

+ const rtc::Optional<uint32_t>& incoming_bitrate,

double noise_var)

: bw_state(bw_state),

incoming_bitrate(incoming_bitrate),

noise_var(noise_var) {}

BandwidthUsage bw_state;

- uint32_t incoming_bitrate;

+ rtc::Optional<uint32_t> incoming_bitrate;

double noise_var;

};

} // namespace webrtc