webrtc/common_video/include/bitrate_adjuster.h - Issue 2029593002: Update RateStatistics to handle too-little-data case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/common_video/include/bitrate_adjuster.h

Issue 2029593002: Update RateStatistics to handle too-little-data case. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Addressed comment Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/common_video/bitrate_adjuster_unittest.cc ('k') | webrtc/modules/remote_bitrate_estimator/aimd_rate_control.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/common_video/include/bitrate_adjuster.h

diff --git a/webrtc/common_video/include/bitrate_adjuster.h b/webrtc/common_video/include/bitrate_adjuster.h

index 1f2474f88b13f6738f797b609e3d18d085141af8..5fd1e3851b1c6369f1cc937a7400c0f8d86fd280 100644

--- a/webrtc/common_video/include/bitrate_adjuster.h

+++ b/webrtc/common_video/include/bitrate_adjuster.h

@@ -47,7 +47,7 @@ class BitrateAdjuster {

uint32_t GetAdjustedBitrateBps() const;

// Returns what we think the current bitrate is.

- uint32_t GetEstimatedBitrateBps();

+ rtc::Optional<uint32_t> GetEstimatedBitrateBps();

// This should be called after each frame is encoded. The timestamp at which

// it is called is used to estimate the output bitrate of the encoder.

« no previous file with comments | « webrtc/common_video/bitrate_adjuster_unittest.cc ('k') | webrtc/modules/remote_bitrate_estimator/aimd_rate_control.h » ('j') | no next file with comments »