webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h - Issue 2029593002: Update RateStatistics to handle too-little-data case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h

Issue 2029593002: Update RateStatistics to handle too-little-data case. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h ('K') | « webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h ('k') | webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc » ('j') | webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h

diff --git a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h

index a6119091ce75f965c69e145dd53555aeafd58383..f02d2322526c6560dcab68bd8cb1fbb04823c89b 100644

--- a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h

+++ b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h

@@ -124,6 +124,7 @@ class RemoteBitrateEstimatorAbsSendTime : public RemoteBitrateEstimator {

std::unique_ptr<OveruseEstimator> estimator_;

OveruseDetector detector_;

RateStatistics incoming_bitrate_;

+ uint32_t last_valid_incoming_bitrate_;

stefan-webrtc 2016/06/02 07:16:41 Possibly change this to: Optional<uint32_t> last_i

sprang_webrtc 2016/06/02 08:09:32 Actually, the way intended to use this (save it to

std::vector<int> recent_propagation_delta_ms_;

std::vector<int64_t> recent_update_time_ms_;

std::list<Probe> probes_;