Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2029583002: Remove test targets of type none. (Closed)

Created:
4 years, 6 months ago by kjellander_webrtc
Modified:
4 years, 6 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove test targets of type none. Move the sources of rtc_unittests and xmllite_xmpp_unittests into the actual targets instead of depending on none-targets. This will make it easier to create GN targets matching them. BUG=webrtc:5949 NOTRY=True NOPRESUBMIT=True Committed: https://crrev.com/26306b139a5c153157f4d7e6b400a1047d427de7 Cr-Commit-Position: refs/heads/master@{#13008}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -238 lines) Patch
M webrtc/base/base_tests.gyp View 1 chunk +0 lines, -137 lines 0 comments Download
M webrtc/libjingle/xmllite/xmllite.gyp View 1 chunk +0 lines, -20 lines 0 comments Download
M webrtc/libjingle/xmpp/xmpp.gyp View 1 chunk +0 lines, -29 lines 0 comments Download
M webrtc/p2p/p2p.gyp View 1 chunk +0 lines, -48 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 2 chunks +184 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
kjellander_webrtc
4 years, 6 months ago (2016-06-01 15:21:53 UTC) #2
phoglund
lgtm
4 years, 6 months ago (2016-06-02 08:41:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029583002/1
4 years, 6 months ago (2016-06-02 09:19:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6024)
4 years, 6 months ago (2016-06-02 09:22:46 UTC) #8
kjellander_webrtc
On 2016/06/02 09:22:46, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 6 months ago (2016-06-02 09:25:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029583002/1
4 years, 6 months ago (2016-06-02 09:25:55 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 09:26:07 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 09:26:17 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26306b139a5c153157f4d7e6b400a1047d427de7
Cr-Commit-Position: refs/heads/master@{#13008}

Powered by Google App Engine
This is Rietveld 408576698