Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: webrtc/base/signalthread_unittest.cc

Issue 2029523002: Disabled two flaky subtests of SignalThreadTest. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/signalthread_unittest.cc
diff --git a/webrtc/base/signalthread_unittest.cc b/webrtc/base/signalthread_unittest.cc
index 57190128c5347bafcf31289e348ad904d654a72d..95b4ac1d6e600de0e28228b72bba36d6ee417aa7 100644
--- a/webrtc/base/signalthread_unittest.cc
+++ b/webrtc/base/signalthread_unittest.cc
@@ -159,7 +159,12 @@ TEST_F(SignalThreadTest, OwnerThreadGoesAway) {
EXPECT_EQ(stopped, thread_stopped_); \
EXPECT_EQ(deleted, thread_deleted_);
-TEST_F(SignalThreadTest, ThreadFinishes) {
+#if defined(WEBRTC_LINUX)
+#define MAYBE_ThreadFinishes DISABLED_ThreadFinishes
+#else
+#define MAYBE_ThreadFinishes ThreadFinishes
+#endif
+TEST_F(SignalThreadTest, MAYBE_ThreadFinishes) {
thread_->Start();
EXPECT_STATE(1, 0, 0, 0, 0);
Thread::SleepMs(500);
@@ -168,7 +173,12 @@ TEST_F(SignalThreadTest, ThreadFinishes) {
EXPECT_STATE(1, 1, 1, 0, 1);
}
-TEST_F(SignalThreadTest, ReleasedThreadFinishes) {
+#if defined(WEBRTC_LINUX)
+#define MAYBE_ReleasedThreadFinishes DISABLED_ReleasedThreadFinishes
+#else
+#define MAYBE_ReleasedThreadFinishes ReleasedThreadFinishes
+#endif
+TEST_F(SignalThreadTest, MAYBE_ReleasedThreadFinishes) {
thread_->Start();
EXPECT_STATE(1, 0, 0, 0, 0);
thread_->Release();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698