Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2029523002: Disabled two flaky subtests of SignalThreadTest. (Closed)

Created:
4 years, 6 months ago by ossu
Modified:
4 years, 6 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disabled two flaky subtests of SignalThreadTest. BUG=webrtc:5953 Committed: https://crrev.com/a8aa9076391a328e54b97673b60baa03f8d9795e Cr-Commit-Position: refs/heads/master@{#13019}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M webrtc/base/signalthread_unittest.cc View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ossu
Disabled another flaky test.
4 years, 6 months ago (2016-06-01 08:03:39 UTC) #2
tommi
lgtm
4 years, 6 months ago (2016-06-01 12:49:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029523002/1
4 years, 6 months ago (2016-06-02 14:22:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_clang_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_clang_dbg/builds/2812)
4 years, 6 months ago (2016-06-02 14:31:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2029523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2029523002/1
4 years, 6 months ago (2016-06-02 15:22:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 15:47:12 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 15:47:16 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a8aa9076391a328e54b97673b60baa03f8d9795e
Cr-Commit-Position: refs/heads/master@{#13019}

Powered by Google App Engine
This is Rietveld 408576698