New static method I420Buffer::SetToBlack.

New static method I420Buffer::SetToBlack.

Replaces cricket::VideoFrame::SetToBlack and
cricket::WebRtcVideoFrame::InitToBlack, which are deleted.

Refactors the black frame logic in VideoBroadcaster, and a few of the
tests.

BUG=webrtc:5682
Committed: https://crrev.com/663f9e2ddc86e813f6db04ba2cf5ac1ed9e7ef67
Cr-Commit-Position: refs/heads/master@{#13063}

[nisse-webrtc, 2016-06-02 12:38:29]

nisse@webrtc.org changed reviewers:
+ pbos@webrtc.org, perkj@webrtc.org

[nisse-webrtc, 2016-06-02 12:38:30]

Adds SetToBlack as a static method on I420Buffer, and deletes corresponding
VideoFrame methods.

[perkj_webrtc, 2016-06-02 13:20:04]

lgtm if the below is addressed.

https://codereview.webrtc.org/2029273004/diff/1/webrtc/common_video/include/v...
File webrtc/common_video/include/video_frame_buffer.h (right):

https://codereview.webrtc.org/2029273004/diff/1/webrtc/common_video/include/v...
webrtc/common_video/include/video_frame_buffer.h:114: const
rtc::scoped_refptr<VideoFrameBuffer>& buffer);
Why not make a member and put after InitializeData(); (and docment what
InitializeData does please...)

https://codereview.webrtc.org/2029273004/diff/1/webrtc/media/base/fakevideore...
File webrtc/media/base/fakevideorenderer.h (right):

https://codereview.webrtc.org/2029273004/diff/1/webrtc/media/base/fakevideore...
webrtc/media/base/fakevideorenderer.h:35: // TODO(zhurunz) Check with VP8 team
to see if we can remove this
remove this TODO if this works.

[nisse-webrtc, 2016-06-03 14:22:50]

pbos, do you have any opinions? You own some of the affected files.

https://codereview.webrtc.org/2029273004/diff/1/webrtc/common_video/include/v...
File webrtc/common_video/include/video_frame_buffer.h (right):

https://codereview.webrtc.org/2029273004/diff/1/webrtc/common_video/include/v...
webrtc/common_video/include/video_frame_buffer.h:114: const
rtc::scoped_refptr<VideoFrameBuffer>& buffer);
On 2016/06/02 13:20:04, perkj_webrtc wrote:
> Why not make a member and put after InitializeData(); (and docment what
> InitializeData does please...)

Done.

https://codereview.webrtc.org/2029273004/diff/1/webrtc/media/base/fakevideore...
File webrtc/media/base/fakevideorenderer.h (right):

https://codereview.webrtc.org/2029273004/diff/1/webrtc/media/base/fakevideore...
webrtc/media/base/fakevideorenderer.h:35: // TODO(zhurunz) Check with VP8 team
to see if we can remove this
On 2016/06/02 13:20:04, perkj_webrtc wrote:
> remove this TODO if this works.

I logged the largest Y value seen  supposedly black frames, and the largest
value seen when run rtc_media_unittests and peerconnection_unittests were 34.

So using 48 as the upper bound seems quite reasonable.

[pbos-webrtc, 2016-06-03 14:46:02]

lgtm

https://codereview.webrtc.org/2029273004/diff/1/webrtc/media/base/fakevideore...
File webrtc/media/base/fakevideorenderer.h (right):

https://codereview.webrtc.org/2029273004/diff/1/webrtc/media/base/fakevideore...
webrtc/media/base/fakevideorenderer.h:35: // TODO(zhurunz) Check with VP8 team
to see if we can remove this
On 2016/06/03 14:22:50, nisse-webrtc wrote:
> On 2016/06/02 13:20:04, perkj_webrtc wrote:
> > remove this TODO if this works.
> 
> I logged the largest Y value seen  supposedly black frames, and the largest
> value seen when run rtc_media_unittests and peerconnection_unittests were 34.
> 
> So using 48 as the upper bound seems quite reasonable.

That means that we cannot remove it right? Update the comment to say why we
permit non-exact Y?

[nisse-webrtc, 2016-06-08 09:25:28]

https://codereview.webrtc.org/2029273004/diff/1/webrtc/media/base/fakevideore...
File webrtc/media/base/fakevideorenderer.h (right):

https://codereview.webrtc.org/2029273004/diff/1/webrtc/media/base/fakevideore...
webrtc/media/base/fakevideorenderer.h:35: // TODO(zhurunz) Check with VP8 team
to see if we can remove this
On 2016/06/03 14:46:02, pbos-webrtc wrote:
> On 2016/06/03 14:22:50, nisse-webrtc wrote:
> > On 2016/06/02 13:20:04, perkj_webrtc wrote:
> > > remove this TODO if this works.
> > 
> > I logged the largest Y value seen  supposedly black frames, and the largest
> > value seen when run rtc_media_unittests and peerconnection_unittests were
34.
> > 
> > So using 48 as the upper bound seems quite reasonable.
> 
> That means that we cannot remove it right? Update the comment to say why we
> permit non-exact Y?

Done.

[nisse-webrtc, 2016-06-08 09:25:34]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-06-08 09:25:35]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org,
pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2029273004/#ps40001 (title:
"Update TODO comment.")

[commit-bot: I haz the power, 2016-06-08 09:25:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2029273004/40001

[commit-bot: I haz the power, 2016-06-08 09:34:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 09:34:57]

Try jobs failed on following builders:
  linux_ubsan_vptr on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds...)

[nisse-webrtc, 2016-06-08 10:15:49]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-06-08 10:15:49]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org,
perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2029273004/#ps60001 (title:
"Add missing SetToBlack call.")

[commit-bot: I haz the power, 2016-06-08 10:15:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2029273004/60001

[commit-bot: I haz the power, 2016-06-08 11:26:27]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-08 11:26:33]

Description was changed from

==========
New static method I420Buffer::SetToBlack.

Replaces cricket::VideoFrame::SetToBlack and
cricket::WebRtcVideoFrame::InitToBlack, which are deleted.

Refactors the black frame logic in VideoBroadcaster, and a few of the
tests.

BUG=webrtc:5682
==========

to

==========
New static method I420Buffer::SetToBlack.

Replaces cricket::VideoFrame::SetToBlack and
cricket::WebRtcVideoFrame::InitToBlack, which are deleted.

Refactors the black frame logic in VideoBroadcaster, and a few of the
tests.

BUG=webrtc:5682

Committed: https://crrev.com/663f9e2ddc86e813f6db04ba2cf5ac1ed9e7ef67
Cr-Commit-Position: refs/heads/master@{#13063}
==========

[commit-bot: I haz the power, 2016-06-08 11:26:35]

Patchset 4 (id:??) landed as
https://crrev.com/663f9e2ddc86e813f6db04ba2cf5ac1ed9e7ef67
Cr-Commit-Position: refs/heads/master@{#13063}

[nisse-webrtc, 2016-06-08 12:20:45]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.webrtc.org/2049023002/ by nisse@webrtc.org.

The reason for reverting is: Breaks chrome, in particular, the tests in 

media_stream_remote_video_source_unittest.cc

use the InitToBlack method which is being deleted..