Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2028643002: VideoCapturerAndroid: Check that camera is still running in every *OnCameraThread method (Closed)

Created:
4 years, 6 months ago by magjed_webrtc
Modified:
4 years, 6 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

VideoCapturerAndroid: Check that camera is still running in every *OnCameraThread method removeCallbacksAndMessages() is called on the camera thread handler before setting it to null to remove all pending runnables. The purpose is to make sure *OnCameraThread methods are not executed when the camera is stopped, but this does not seem to work reliably. This CL resorts to a belt and braces approach and checks that the the handler is still alive in all *OnCameraThread methods. BUG=b/29015569 R=sakal@webrtc.org Committed: https://crrev.com/2e646c8729f9ca6a07663d9e0ffa82a380742f5d Cr-Commit-Position: refs/heads/master@{#12981}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -41 lines) Patch
M webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java View 10 chunks +74 lines, -41 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
magjed_webrtc
Sami - Please take a look.
4 years, 6 months ago (2016-05-31 14:24:19 UTC) #3
sakal
Ugly but lgtm so we don't crash.
4 years, 6 months ago (2016-05-31 15:20:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028643002/1
4 years, 6 months ago (2016-05-31 15:23:18 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/8297)
4 years, 6 months ago (2016-05-31 16:29:05 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2e646c8729f9ca6a07663d9e0ffa82a380742f5d Cr-Commit-Position: refs/heads/master@{#12981}
4 years, 6 months ago (2016-06-01 07:45:38 UTC) #13
magjed_webrtc
4 years, 6 months ago (2016-06-01 07:45:38 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2e646c8729f9ca6a07663d9e0ffa82a380742f5d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698