Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2028583002: Reland of Android: Change camera fps range selection (Closed)

Created:
4 years, 6 months ago by magjed_webrtc
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Android: Change camera fps range selection (patchset #1 id:1 of https://codereview.webrtc.org/2021233002/ ) Reason for revert: Fixed gyp bug. Original issue's description: > Revert of Android: Change camera fps range selection (patchset #4 id:100001 of https://codereview.webrtc.org/2013413002/ ) > > Reason for revert: > Breaks chromium fyi: > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/13565 > on step 'generate_build_files': > gyp: /b/build/slave/Mac_Builder/build/src/third_party/build/android/test_runner.gypi not found > > Original issue's description: > > Android: Change camera fps range selection > > > > This CL changes the logic in > > CameraEnumerationAndroid.getClosestSupportedFramerateRange() to prefer > > fps ranges with a low lower bound so the camera can adjust for > > brightness conditions. > > > > To test the functionality of the fps range selection, JUnit tests are > > added. This required a new target in api_tests.gyp. JUnit tests are > > preferable over instrumentation tests > > (libjingle_peerconnection_android_unittest) because they are faster and > > simpler. > > > > R=kjellander@webrtc.org, sakal@webrtc.org > > > > Committed: https://crrev.com/b4ddb5c3d3706b1c02437f6a538576f3552ab908 > > Cr-Commit-Position: refs/heads/master@{#12964} > > TBR=sakal@webrtc.org,kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/b3f208d0ba45f140272e3e705b5cdadc3c76514b > Cr-Commit-Position: refs/heads/master@{#12966} TBR=sakal@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/ce17e01bf6609a65e3efa5dac27daf13eee85c48 Cr-Commit-Position: refs/heads/master@{#12980}

Patch Set 1 #

Patch Set 2 : Fix gyp problems #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -7 lines) Patch
A + webrtc/androidjunit/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A webrtc/androidjunit/src/org/webrtc/CameraEnumerationTest.java View 1 chunk +55 lines, -0 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/CameraEnumerationAndroid.java View 1 1 chunk +24 lines, -2 lines 0 comments Download
M webrtc/build/android_tests.gyp View 1 16 chunks +36 lines, -5 lines 0 comments Download
M webrtc/build/android_tests_noop.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
magjed_webrtc
Created Reland of Android: Change camera fps range selection
4 years, 6 months ago (2016-05-31 11:26:58 UTC) #1
kjellander_webrtc
I'm assuming there'll be a PS#2 with the fix?
4 years, 6 months ago (2016-05-31 11:46:03 UTC) #2
kjellander_webrtc
On 2016/05/31 11:46:03, kjellander_webrtc wrote: > I'm assuming there'll be a PS#2 with the fix? ...
4 years, 6 months ago (2016-05-31 11:46:42 UTC) #3
magjed_webrtc
kjellander@ - Please take another look.
4 years, 6 months ago (2016-05-31 14:21:48 UTC) #4
kjellander_webrtc
lgtm
4 years, 6 months ago (2016-05-31 20:01:16 UTC) #5
sakal
lgtm
4 years, 6 months ago (2016-06-01 07:05:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028583002/110001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2028583002/110001
4 years, 6 months ago (2016-06-01 07:43:55 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:110001)
4 years, 6 months ago (2016-06-01 07:44:04 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 07:44:11 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ce17e01bf6609a65e3efa5dac27daf13eee85c48
Cr-Commit-Position: refs/heads/master@{#12980}

Powered by Google App Engine
This is Rietveld 408576698