Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1551)

Issue 2028543002: [rtcp] Nack::Parse updated not to use RTCPUtility (Closed)

Created:
4 years, 6 months ago by danilchap
Modified:
4 years, 4 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtcp] Nack::Parse updated not to use RTCPUtility BUG=webrtc:5260 R=åsapersson Committed: https://crrev.com/95e756035eb03971b8c66caa74b444094306562a Cr-Commit-Position: refs/heads/master@{#13586}

Patch Set 1 #

Patch Set 2 : rebase & nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -91 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_packet/nack.h View 1 2 chunks +6 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/nack.cc View 1 4 chunks +33 lines, -27 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/nack_unittest.cc View 1 6 chunks +46 lines, -56 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
åsapersson
lgtm
4 years, 4 months ago (2016-08-01 12:15:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2028543002/20001
4 years, 4 months ago (2016-08-01 12:57:51 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-01 13:51:17 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 13:51:25 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/95e756035eb03971b8c66caa74b444094306562a
Cr-Commit-Position: refs/heads/master@{#13586}

Powered by Google App Engine
This is Rietveld 408576698