Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2028403003: Restart avfoundationvideocapturer on errors. (Closed)

Created:
4 years, 6 months ago by tkchin_webrtc
Modified:
4 years, 6 months ago
Reviewers:
Chuck
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Restart avfoundationvideocapturer on errors. NOTRY=True BUG= R=haysc@webrtc.org Committed: https://crrev.com/5251680ec35cf6687fcee902a7aff3375fb0330b Cr-Commit-Position: refs/heads/master@{#13041}

Patch Set 1 #

Patch Set 2 : Remove deprecated error type #

Patch Set 3 : #

Patch Set 4 : Avoid potential crash. #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -25 lines) Patch
M webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm View 1 2 3 4 10 chunks +157 lines, -25 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
tkchin_webrtc
Speculative. I haven't been able to make the camera behave badly intentionally.
4 years, 6 months ago (2016-06-02 22:49:46 UTC) #3
Chuck
LGTM https://codereview.webrtc.org/2028403003/diff/60001/webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm File webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm (right): https://codereview.webrtc.org/2028403003/diff/60001/webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm#newcode75 webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm:75: @synthesize hasStarted = _hasStarted; Do you want to ...
4 years, 6 months ago (2016-06-03 14:04:39 UTC) #4
tkchin_webrtc
https://codereview.webrtc.org/2028403003/diff/60001/webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm File webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm (right): https://codereview.webrtc.org/2028403003/diff/60001/webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm#newcode75 webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm:75: @synthesize hasStarted = _hasStarted; On 2016/06/03 14:04:39, Chuck wrote: ...
4 years, 6 months ago (2016-06-03 17:54:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028403003/80001
4 years, 6 months ago (2016-06-03 18:47:37 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6078)
4 years, 6 months ago (2016-06-03 18:50:24 UTC) #11
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/5251680ec35cf6687fcee902a7aff3375fb0330b Cr-Commit-Position: refs/heads/master@{#13041}
4 years, 6 months ago (2016-06-03 18:57:28 UTC) #14
tkchin_webrtc
Committed patchset #5 (id:80001) manually as 5251680ec35cf6687fcee902a7aff3375fb0330b (presubmit successful).
4 years, 6 months ago (2016-06-03 18:57:28 UTC) #15
tkchin_webrtc
4 years, 6 months ago (2016-06-03 18:58:40 UTC) #16 
Landed manually because presubmit is complaining about long lines, and there's
not really a good way to make that constant name fit in 80 chars.

I'll update presubmit script to accept 100 lines for ObjC files separately.

Powered by Google App Engine
This is Rietveld 408576698