Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Unified Diff: webrtc/api/dtlsidentitystore_unittest.cc

Issue 2028033002: Remove DtlsIdentityStoreImpl and RTCCertificateGeneratorStoreWrapper. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/api/dtlsidentitystore.cc ('K') | « webrtc/api/dtlsidentitystore.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/dtlsidentitystore_unittest.cc
diff --git a/webrtc/api/dtlsidentitystore_unittest.cc b/webrtc/api/dtlsidentitystore_unittest.cc
deleted file mode 100644
index 31f0113f283752072fde47a018ee5556e58e4e57..0000000000000000000000000000000000000000
--- a/webrtc/api/dtlsidentitystore_unittest.cc
+++ /dev/null
@@ -1,147 +0,0 @@
-/*
- * Copyright 2015 The WebRTC project authors. All Rights Reserved.
- *
- * Use of this source code is governed by a BSD-style license
- * that can be found in the LICENSE file in the root of the source
- * tree. An additional intellectual property rights grant can be found
- * in the file PATENTS. All contributing project authors may
- * be found in the AUTHORS file in the root of the source tree.
- */
-
-#include "webrtc/api/dtlsidentitystore.h"
-
-#include <memory>
-
-#include "webrtc/api/webrtcsessiondescriptionfactory.h"
-#include "webrtc/base/gunit.h"
-#include "webrtc/base/logging.h"
-#include "webrtc/base/ssladapter.h"
-
-using webrtc::DtlsIdentityStoreImpl;
-
-static const int kTimeoutMs = 10000;
-
-class MockDtlsIdentityRequestObserver :
- public webrtc::DtlsIdentityRequestObserver {
- public:
- MockDtlsIdentityRequestObserver()
- : call_back_called_(false), last_request_success_(false) {}
- void OnFailure(int error) override {
- EXPECT_FALSE(call_back_called_);
- call_back_called_ = true;
- last_request_success_ = false;
- }
- void OnSuccess(const std::string& der_cert,
- const std::string& der_private_key) override {
- LOG(LS_WARNING) << "The string version of OnSuccess is called unexpectedly";
- EXPECT_TRUE(false);
- }
- void OnSuccess(std::unique_ptr<rtc::SSLIdentity> identity) override {
- EXPECT_FALSE(call_back_called_);
- call_back_called_ = true;
- last_request_success_ = true;
- }
-
- void Reset() {
- call_back_called_ = false;
- last_request_success_ = false;
- }
-
- bool LastRequestSucceeded() const {
- return call_back_called_ && last_request_success_;
- }
-
- bool call_back_called() const {
- return call_back_called_;
- }
-
- private:
- bool call_back_called_;
- bool last_request_success_;
-};
-
-class DtlsIdentityStoreTest : public testing::Test {
- protected:
- DtlsIdentityStoreTest()
- : worker_thread_(new rtc::Thread()),
- store_(new DtlsIdentityStoreImpl(rtc::Thread::Current(),
- worker_thread_.get())),
- observer_(
- new rtc::RefCountedObject<MockDtlsIdentityRequestObserver>()) {
- RTC_CHECK(worker_thread_->Start());
- }
- ~DtlsIdentityStoreTest() {}
-
- static void SetUpTestCase() {
- rtc::InitializeSSL();
- }
- static void TearDownTestCase() {
- rtc::CleanupSSL();
- }
-
- std::unique_ptr<rtc::Thread> worker_thread_;
- std::unique_ptr<DtlsIdentityStoreImpl> store_;
- rtc::scoped_refptr<MockDtlsIdentityRequestObserver> observer_;
-};
-
-TEST_F(DtlsIdentityStoreTest, RequestIdentitySuccessRSA) {
- store_->RequestIdentity(rtc::KeyParams(rtc::KT_RSA),
- rtc::Optional<uint64_t>(),
- observer_.get());
- EXPECT_TRUE_WAIT(observer_->LastRequestSucceeded(), kTimeoutMs);
-
- EXPECT_TRUE_WAIT(store_->HasFreeIdentityForTesting(rtc::KT_RSA), kTimeoutMs);
-
- observer_->Reset();
-
- // Verifies that the callback is async when a free identity is ready.
- store_->RequestIdentity(rtc::KeyParams(rtc::KT_RSA),
- rtc::Optional<uint64_t>(),
- observer_.get());
- EXPECT_FALSE(observer_->call_back_called());
- EXPECT_TRUE_WAIT(observer_->LastRequestSucceeded(), kTimeoutMs);
-}
-
-TEST_F(DtlsIdentityStoreTest, RequestIdentitySuccessECDSA) {
- store_->RequestIdentity(rtc::KeyParams(rtc::KT_ECDSA),
- rtc::Optional<uint64_t>(),
- observer_.get());
- EXPECT_TRUE_WAIT(observer_->LastRequestSucceeded(), kTimeoutMs);
-
- // Since store currently does not preemptively generate free ECDSA identities
- // we do not invoke HasFreeIdentityForTesting between requests.
-
- observer_->Reset();
-
- // Verifies that the callback is async when a free identity is ready.
- store_->RequestIdentity(rtc::KeyParams(rtc::KT_ECDSA),
- rtc::Optional<uint64_t>(),
- observer_.get());
- EXPECT_FALSE(observer_->call_back_called());
- EXPECT_TRUE_WAIT(observer_->LastRequestSucceeded(), kTimeoutMs);
-}
-
-TEST_F(DtlsIdentityStoreTest, DeleteStoreEarlyNoCrashRSA) {
- EXPECT_FALSE(store_->HasFreeIdentityForTesting(rtc::KT_RSA));
-
- store_->RequestIdentity(rtc::KeyParams(rtc::KT_RSA),
- rtc::Optional<uint64_t>(),
- observer_.get());
- store_.reset();
-
- worker_thread_->Stop();
- EXPECT_FALSE(observer_->call_back_called());
-}
-
-TEST_F(DtlsIdentityStoreTest, DeleteStoreEarlyNoCrashECDSA) {
- EXPECT_FALSE(store_->HasFreeIdentityForTesting(rtc::KT_ECDSA));
-
- store_->RequestIdentity(rtc::KeyParams(rtc::KT_ECDSA),
- rtc::Optional<uint64_t>(),
- observer_.get());
- store_.reset();
-
- worker_thread_->Stop();
- EXPECT_FALSE(observer_->call_back_called());
-}
-
« webrtc/api/dtlsidentitystore.cc ('K') | « webrtc/api/dtlsidentitystore.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698