Remove DtlsIdentityStoreImpl and RTCCertificateGeneratorStoreWrapper.

Remove DtlsIdentityStoreImpl and RTCCertificateGeneratorStoreWrapper.

The DtlsIdentityStoreInterface has been replaced by
RTCCertificateGenerator. Due to previous CLs, neither the
DtlsIdentityStoreImpl or RTCCertificateGeneratorStoreWrapper are used.

DtlsIdentityStoreInterface is still implemented by
PeerConnectionIdentityStore in Chromium and is not removed, but it will
be soon.

BUG=webrtc:5708
R=tommi@webrtc.org

Committed: https://crrev.com/01cdab192271f8df1f17a36d50b40f0caf003382
Cr-Commit-Position: refs/heads/master@{#13004}

[hbos, 2016-06-01 12:32:24]

hbos@webrtc.org changed reviewers:
+ tommi@webrtc.org

[hbos, 2016-06-01 12:32:25]

Please take a look tommi

[tommi, 2016-06-01 12:36:31]

https://codereview.webrtc.org/2028033002/diff/1/webrtc/api/dtlsidentitystore.cc
File webrtc/api/dtlsidentitystore.cc (right):

https://codereview.webrtc.org/2028033002/diff/1/webrtc/api/dtlsidentitystore....
webrtc/api/dtlsidentitystore.cc:17: const char kIdentityName[] = "WebRTC";
can we move this constant to where it is used and delete this file?

[hbos, 2016-06-01 13:19:17]

Patchset #2 (id:20001) has been deleted

[hbos, 2016-06-01 13:39:25]

Patchset #2 (id:40001) has been deleted

[hbos, 2016-06-01 13:39:30]

Patchset #2 (id:60001) has been deleted

[hbos, 2016-06-01 13:41:48]

PTAL tommi: Can I land this and address comment in follow-up?

https://codereview.webrtc.org/2028033002/diff/1/webrtc/api/dtlsidentitystore.cc
File webrtc/api/dtlsidentitystore.cc (right):

https://codereview.webrtc.org/2028033002/diff/1/webrtc/api/dtlsidentitystore....
webrtc/api/dtlsidentitystore.cc:17: const char kIdentityName[] = "WebRTC";
On 2016/06/01 12:36:31, tommi-webrtc wrote:
> can we move this constant to where it is used and delete this file?

Yes, but can I do that in a separate CL?

Turns out the only usage was RTCPeerConnectionInterface.mm where it was used
with SSLIdentity::Generate. This code should have been using
RTCCertificateGenerator instead and not needed the constant. Anyway, it requires
.mm changes which requires tkchin reviewing and also I might want/have to do
other related .mm cleanup, so a separate CL would be nicer for all of that.

[hbos, 2016-06-01 13:58:35]

The CQ bit was checked by hbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-01 13:58:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028033002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028033002/1

[tommi, 2016-06-01 14:27:06]

On 2016/06/01 13:41:48, hbos wrote:
> PTAL tommi: Can I land this and address comment in follow-up?
> 
>
https://codereview.webrtc.org/2028033002/diff/1/webrtc/api/dtlsidentitystore.cc
> File webrtc/api/dtlsidentitystore.cc (right):
> 
>
https://codereview.webrtc.org/2028033002/diff/1/webrtc/api/dtlsidentitystore....
> webrtc/api/dtlsidentitystore.cc:17: const char kIdentityName[] = "WebRTC";
> On 2016/06/01 12:36:31, tommi-webrtc wrote:
> > can we move this constant to where it is used and delete this file?
> 
> Yes, but can I do that in a separate CL?
> 
> Turns out the only usage was RTCPeerConnectionInterface.mm where it was used
> with SSLIdentity::Generate. This code should have been using
> RTCCertificateGenerator instead and not needed the constant. Anyway, it
requires
> .mm changes which requires tkchin reviewing and also I might want/have to do
> other related .mm cleanup, so a separate CL would be nicer for all of that.

OK.  Can you leave a TODO then with that information (where to move the
constant)?
lgtm as is then.

[hbos, 2016-06-01 15:21:19]

The CQ bit was checked by hbos@webrtc.org

[hbos, 2016-06-01 15:21:19]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2028033002/#ps80001 (title:
"Added TODO ")

[commit-bot: I haz the power, 2016-06-01 15:21:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2028033002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2028033002/80001

[commit-bot: I haz the power, 2016-06-01 17:22:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 17:22:01]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[hbos, 2016-06-02 08:18:31]

Description was changed from

==========
Remove DtlsIdentityStoreImpl and RTCCertificateGeneratorStoreWrapper.

The DtlsIdentityStoreInterface has been replaced by
RTCCertificateGenerator. Due to previous CLs, neither the
DtlsIdentityStoreImpl or RTCCertificateGeneratorStoreWrapper are used.

DtlsIdentityStoreInterface is still implemented by
PeerConnectionIdentityStore in Chromium and is not removed, but it will
be soon.

BUG=webrtc:5708
==========

to

==========
Remove DtlsIdentityStoreImpl and RTCCertificateGeneratorStoreWrapper.

The DtlsIdentityStoreInterface has been replaced by
RTCCertificateGenerator. Due to previous CLs, neither the
DtlsIdentityStoreImpl or RTCCertificateGeneratorStoreWrapper are used.

DtlsIdentityStoreInterface is still implemented by
PeerConnectionIdentityStore in Chromium and is not removed, but it will
be soon.

BUG=webrtc:5708
R=tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/01cdab192271f8df1f17a36d5...
==========

[hbos, 2016-06-02 08:18:32]

Committed patchset #2 (id:80001) manually as
01cdab192271f8df1f17a36d50b40f0caf003382 (presubmit successful).

[commit-bot: I haz the power, 2016-06-02 08:18:37]

Description was changed from

==========
Remove DtlsIdentityStoreImpl and RTCCertificateGeneratorStoreWrapper.

The DtlsIdentityStoreInterface has been replaced by
RTCCertificateGenerator. Due to previous CLs, neither the
DtlsIdentityStoreImpl or RTCCertificateGeneratorStoreWrapper are used.

DtlsIdentityStoreInterface is still implemented by
PeerConnectionIdentityStore in Chromium and is not removed, but it will
be soon.

BUG=webrtc:5708
R=tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/01cdab192271f8df1f17a36d5...
==========

to

==========
Remove DtlsIdentityStoreImpl and RTCCertificateGeneratorStoreWrapper.

The DtlsIdentityStoreInterface has been replaced by
RTCCertificateGenerator. Due to previous CLs, neither the
DtlsIdentityStoreImpl or RTCCertificateGeneratorStoreWrapper are used.

DtlsIdentityStoreInterface is still implemented by
PeerConnectionIdentityStore in Chromium and is not removed, but it will
be soon.

BUG=webrtc:5708
R=tommi@webrtc.org

Committed: https://crrev.com/01cdab192271f8df1f17a36d50b40f0caf003382
Cr-Commit-Position: refs/heads/master@{#13004}
==========