Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2027573002: Disabled RestartingSendStreamPreservesRtpStatesWithRtx on Mac due to flakiness. (Closed)

Created:
4 years, 6 months ago by ossu
Modified:
4 years, 6 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disabled RestartingSendStreamPreservesRtpStatesWithRtx on Mac due to flakiness. I have not seen it crop up on other platforms, so limiting the disable to just Mac for now. See, for example: https://build.chromium.org/p/client.webrtc/builders/Mac64%20Debug/builds/7339/steps/video_engine_tests/logs/stdio BUG=webrtc:4332 Committed: https://crrev.com/799467d753e999e30249028c6a3a18e95684c4bc Cr-Commit-Position: refs/heads/master@{#12973}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M webrtc/video/end_to_end_tests.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
ossu
Please take a look!
4 years, 6 months ago (2016-05-31 09:38:10 UTC) #3
pbos-webrtc
lgtm
4 years, 6 months ago (2016-05-31 10:13:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027573002/1
4 years, 6 months ago (2016-05-31 10:50:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 12:17:37 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 12:17:47 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/799467d753e999e30249028c6a3a18e95684c4bc
Cr-Commit-Position: refs/heads/master@{#12973}

Powered by Google App Engine
This is Rietveld 408576698