Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1450)

Issue 2026223002: Remove metrics_default from rtc_media dependencies. (Closed)

Created:
4 years, 6 months ago by kjellander_webrtc
Modified:
4 years, 6 months ago
Reviewers:
andresp
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove metrics_default from rtc_media dependencies. By not providing the default implementation of the metrics API it becomes possible for users of rtc_media to choose which implementation to use. The dependency is moved into each test target that uses it instead. NOTRY=True NOPRESUBMIT=True Committed: https://crrev.com/98bba3981685bc61442a6e0f2bca70eb90d7837a Cr-Commit-Position: refs/heads/master@{#12991}

Patch Set 1 #

Patch Set 2 : Add Android and Mac/iOS specific dependencies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M talk/app/webrtc/legacy_objc_api_tests.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/api/api.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/api_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/media.gyp View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/pc/pc.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/sdk.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/sdk_tests.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/webrtc_examples.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
kjellander_webrtc
4 years, 6 months ago (2016-06-01 07:43:34 UTC) #3
andresp
On 2016/06/01 07:43:34, kjellander_webrtc wrote: lgtm
4 years, 6 months ago (2016-06-01 12:23:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026223002/20001
4 years, 6 months ago (2016-06-01 12:25:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6003)
4 years, 6 months ago (2016-06-01 12:27:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026223002/20001
4 years, 6 months ago (2016-06-01 12:28:47 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 12:28:58 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 12:29:02 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/98bba3981685bc61442a6e0f2bca70eb90d7837a
Cr-Commit-Position: refs/heads/master@{#12991}

Powered by Google App Engine
This is Rietveld 408576698