Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: webrtc/api/webrtcsession.cc

Issue 2025573002: Use continual gathering to restore backup connections (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Merge again Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/webrtcsession_unittest.cc » ('j') | webrtc/p2p/base/portallocator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/webrtcsession.cc
diff --git a/webrtc/api/webrtcsession.cc b/webrtc/api/webrtcsession.cc
index 9801d58f174939ded34c1fdd99261f798cb21e4d..287e759544c816d76e6777b5758cdc6ac85493e6 100644
--- a/webrtc/api/webrtcsession.cc
+++ b/webrtc/api/webrtcsession.cc
@@ -1128,14 +1128,27 @@ bool WebRtcSession::RemoveRemoteIceCandidates(
cricket::IceConfig WebRtcSession::ParseIceConfig(
const PeerConnectionInterface::RTCConfiguration& config) const {
+ cricket::ContinualGatheringPolicy gathering_policy;
+ // TODO(honghaiz): Add the third continual gathering policy in
+ // PeerConnectionInterface and map it to GATHER_CONTINUALLY_AND_RECOVER.
+ switch (config.continual_gathering_policy) {
+ case PeerConnectionInterface::GATHER_ONCE:
+ gathering_policy = cricket::GATHER_ONCE;
+ break;
+ case PeerConnectionInterface::GATHER_CONTINUALLY:
+ gathering_policy = cricket::GATHER_CONTINUALLY;
+ break;
+ default:
+ RTC_DCHECK(false);
+ gathering_policy = cricket::GATHER_ONCE;
+ }
cricket::IceConfig ice_config;
ice_config.receiving_timeout = config.ice_connection_receiving_timeout;
ice_config.prioritize_most_likely_candidate_pairs =
config.prioritize_most_likely_ice_candidate_pairs;
ice_config.backup_connection_ping_interval =
config.ice_backup_candidate_pair_ping_interval;
- ice_config.gather_continually = (config.continual_gathering_policy ==
- PeerConnectionInterface::GATHER_CONTINUALLY);
+ ice_config.continual_gathering_policy = gathering_policy;
return ice_config;
}
« no previous file with comments | « no previous file | webrtc/api/webrtcsession_unittest.cc » ('j') | webrtc/p2p/base/portallocator.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698