Use continual gathering to restore backup connections

webrtc/api/webrtcsession_unittest.cc

 /*
  *  Copyright 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 2224 matching lines @@
   candidates = local_desc->candidates(kMediaContentIndex0);
   ASSERT_TRUE(candidates != NULL);
   EXPECT_LT(0u, candidates->count());
   candidates = local_desc->candidates(1);
   ASSERT_TRUE(candidates != NULL);
   EXPECT_EQ(0u, candidates->count());
 
   candidates = local_desc->candidates(kMediaContentIndex0);
   size_t num_local_candidates = candidates->count();
   // Enable Continual Gathering
-  session_->SetIceConfig(cricket::IceConfig(-1, -1, true, false, -1, true));
+  cricket::IceConfig config;
+  config.continual_gathering_policy = cricket::GATHER_CONTINUALLY;
+  config.presume_writable_when_fully_relayed = true;

[Taylor Brandstetter, 2016/06/29 22:12:27]

I don't think presume_writable_when_fully_relayed needs to be true for this
test. I accidentally left the parameter as "true" because it switched from being
"fully_relayed_requires_create_permission" to
"presume_writable_when_fully_relayed", which are inverses of each other.

[honghaiz3, 2016/06/30 01:04:21]

Done.

+  session_->SetIceConfig(config);
   // Bring down the network interface to trigger candidate removals.
   RemoveInterface(rtc::SocketAddress(kClientAddrHost1, kClientAddrPort));
   // Verify that all local candidates are removed.
   EXPECT_EQ(0, observer_.num_candidates_removed_);
   EXPECT_EQ_WAIT(num_local_candidates, observer_.num_candidates_removed_,
                  kIceCandidatesTimeout);
   EXPECT_EQ_WAIT(0u, candidates->count(), kIceCandidatesTimeout);
 }
 
 // Tests that if continual gathering is disabled, local candidates won't be
@@ skipping 2001 matching lines @@
 }
 
 // TODO(bemasc): Add a TestIceStatesBundle with BUNDLE enabled.  That test
 // currently fails because upon disconnection and reconnection OnIceComplete is
 // called more than once without returning to IceGatheringGathering.
 
 INSTANTIATE_TEST_CASE_P(WebRtcSessionTests,
                         WebRtcSessionTest,
                         testing::Values(ALREADY_GENERATED,
                                         DTLS_IDENTITY_STORE));