Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2025423003: Adds WebRtcAudioTrack.setSpeakerMute() API (Closed)

Created:
4 years, 6 months ago by henrika_webrtc
Modified:
4 years, 6 months ago
Reviewers:
AlexG
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adds WebRtcAudioTrack.setSpeakerMute() API BUG=NONE Committed: https://crrev.com/b50e84509f119b273301e4ad5191ef25e8dd9d14 Cr-Commit-Position: refs/heads/master@{#13029}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Improved logging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java View 1 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java View 1 4 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
AlexG
lgtm
4 years, 6 months ago (2016-06-02 17:15:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025423003/1
4 years, 6 months ago (2016-06-02 17:15:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_clang_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_clang_dbg/builds/3820)
4 years, 6 months ago (2016-06-02 17:22:28 UTC) #7
AlexG
lgtm https://codereview.webrtc.org/2025423003/diff/1/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java File webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java (right): https://codereview.webrtc.org/2025423003/diff/1/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java#newcode290 webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java:290: Logging.w(TAG, "setSpeakerMute(" + mute + ")"); Henrik, can ...
4 years, 6 months ago (2016-06-02 18:56:21 UTC) #8
henrika_webrtc
Will do.
4 years, 6 months ago (2016-06-03 07:36:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025423003/20001
4 years, 6 months ago (2016-06-03 08:48:01 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-03 09:56:24 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 09:56:35 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b50e84509f119b273301e4ad5191ef25e8dd9d14
Cr-Commit-Position: refs/heads/master@{#13029}

Powered by Google App Engine
This is Rietveld 408576698