webrtc/base/base_tests.gyp - Issue 2024813004: Improving the fake clock and using it to fix a flaky STUN timeout test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/base_tests.gyp

Issue 2024813004: Improving the fake clock and using it to fix a flaky STUN timeout test. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fixing another TSan warning. WebRtcSession wasn't completely shut down. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/base/base_tests.gyp

diff --git a/webrtc/base/base_tests.gyp b/webrtc/base/base_tests.gyp

index 2ee115b267650dd8de8ef511fb95aab9a9148eb2..003a1dbf875cb18f420bde298c8270f4107b82df 100644

--- a/webrtc/base/base_tests.gyp

+++ b/webrtc/base/base_tests.gyp

@@ -15,6 +15,8 @@

'unittest_main.cc',

# Also use this as a convenient dumping ground for misc files that are

# included by multiple targets below.

+ 'fakeclock.cc',

+ 'fakeclock.h',

'fakenetwork.h',

'fakesslidentity.h',

'faketaskrunner.h',

@@ -22,6 +24,7 @@

'testbase64.h',

'testechoserver.h',

'testutils.h',

+ 'timedelta.h',

'defines': [

'GTEST_RELATIVE_PATH',

« no previous file with comments | « webrtc/api/webrtcsession_unittest.cc ('k') | webrtc/base/fakeclock.h » ('j') | webrtc/base/fakeclock.cc » ('J')