Improving the fake clock and using it to fix a flaky STUN timeout test.

webrtc/base/signalthread_unittest.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 122 matching lines @@
  private:
   SignalThreadTest* harness_;
   bool has_run_;
   RTC_DISALLOW_COPY_AND_ASSIGN(OwnerThread);
 };
 
 // Test for when the main thread goes away while the
 // signal thread is still working.  This may happen
 // when shutting down the process.
 TEST_F(SignalThreadTest, OwnerThreadGoesAway) {
+  // We don't use |thread_| for this test, so destroy it.
+  thread_->Destroy(true);
+
   {
     std::unique_ptr<OwnerThread> owner(new OwnerThread(this));
     main_thread_ = owner.get();
     owner->Start();
     while (!owner->has_run()) {
       Thread::Current()->socketserver()->Wait(10, false);
     }
   }
   // At this point the main thread has gone away.
   // Give the SignalThread a little time to do its callback,
@@ skipping 40 matching lines @@
   EXPECT_STATE(1, 0, 0, 1, 1);
 }
 
 TEST_F(SignalThreadTest, DeferredDestroyedThreadCleansUp) {
   thread_->Start();
   EXPECT_STATE(1, 0, 0, 0, 0);
   thread_->Destroy(false);
   EXPECT_STATE(1, 0, 0, 1, 0);
   EXPECT_STATE_WAIT(1, 1, 0, 1, 1, kTimeout);
 }