Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2024293003: Fix FakeNetworkPipe to not deliver packet faster than requested. (Closed)

Created:
4 years, 6 months ago by danilchap
Modified:
4 years, 6 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix FakeNetworkPipe to not deliver packet faster than requested. BUG=webrtc:5938 Committed: https://crrev.com/a6a70073fb734e74c411f73fbf711a5143b818b5 Cr-Commit-Position: refs/heads/master@{#12997}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M webrtc/test/fake_network_pipe.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
danilchap
on local machine this test failed 2/100000 before this CL. Didn't fail (0/100000) with this ...
4 years, 6 months ago (2016-06-01 14:28:02 UTC) #2
stefan-webrtc
good catch, lgtm
4 years, 6 months ago (2016-06-01 14:46:33 UTC) #3
stefan-webrtc
good catch, lgtm
4 years, 6 months ago (2016-06-01 14:46:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024293003/1
4 years, 6 months ago (2016-06-01 17:56:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 18:20:47 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 18:20:52 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a6a70073fb734e74c411f73fbf711a5143b818b5
Cr-Commit-Position: refs/heads/master@{#12997}

Powered by Google App Engine
This is Rietveld 408576698