Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: webrtc/pc/mediasession.h

Issue 2024153002: Add RtpHeaderExtension to avoid client breakage (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/base/mediachannel.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 return rtp_header_extensions_; 202 return rtp_header_extensions_;
203 } 203 }
204 void set_rtp_header_extensions(const RtpHeaderExtensions& extensions) { 204 void set_rtp_header_extensions(const RtpHeaderExtensions& extensions) {
205 rtp_header_extensions_ = extensions; 205 rtp_header_extensions_ = extensions;
206 rtp_header_extensions_set_ = true; 206 rtp_header_extensions_set_ = true;
207 } 207 }
208 void AddRtpHeaderExtension(const webrtc::RtpExtension& ext) { 208 void AddRtpHeaderExtension(const webrtc::RtpExtension& ext) {
209 rtp_header_extensions_.push_back(ext); 209 rtp_header_extensions_.push_back(ext);
210 rtp_header_extensions_set_ = true; 210 rtp_header_extensions_set_ = true;
211 } 211 }
212 void AddRtpHeaderExtension(const cricket::RtpHeaderExtension& ext) {
213 webrtc::RtpExtension webrtc_extension;
214 webrtc_extension.uri = ext.uri;
215 webrtc_extension.id = ext.id;
216 rtp_header_extensions_.push_back(webrtc_extension);
217 rtp_header_extensions_set_ = true;
218 }
212 void ClearRtpHeaderExtensions() { 219 void ClearRtpHeaderExtensions() {
213 rtp_header_extensions_.clear(); 220 rtp_header_extensions_.clear();
214 rtp_header_extensions_set_ = true; 221 rtp_header_extensions_set_ = true;
215 } 222 }
216 // We can't always tell if an empty list of header extensions is 223 // We can't always tell if an empty list of header extensions is
217 // because the other side doesn't support them, or just isn't hooked up to 224 // because the other side doesn't support them, or just isn't hooked up to
218 // signal them. For now we assume an empty list means no signaling, but 225 // signal them. For now we assume an empty list means no signaling, but
219 // provide the ClearRtpHeaderExtensions method to allow "no support" to be 226 // provide the ClearRtpHeaderExtensions method to allow "no support" to be
220 // clearly indicated (i.e. when derived from other information). 227 // clearly indicated (i.e. when derived from other information).
221 bool rtp_header_extensions_set() const { 228 bool rtp_header_extensions_set() const {
(...skipping 335 matching lines...) Expand 10 before | Expand all | Expand 10 after
557 void GetSupportedVideoCryptoSuiteNames( 564 void GetSupportedVideoCryptoSuiteNames(
558 std::vector<std::string>* crypto_suite_names); 565 std::vector<std::string>* crypto_suite_names);
559 void GetSupportedDataCryptoSuiteNames( 566 void GetSupportedDataCryptoSuiteNames(
560 std::vector<std::string>* crypto_suite_names); 567 std::vector<std::string>* crypto_suite_names);
561 void GetDefaultSrtpCryptoSuiteNames( 568 void GetDefaultSrtpCryptoSuiteNames(
562 std::vector<std::string>* crypto_suite_names); 569 std::vector<std::string>* crypto_suite_names);
563 570
564 } // namespace cricket 571 } // namespace cricket
565 572
566 #endif // WEBRTC_PC_MEDIASESSION_H_ 573 #endif // WEBRTC_PC_MEDIASESSION_H_
OLDNEW
« no previous file with comments | « webrtc/media/base/mediachannel.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698