RFC 3984 sprop-parameter-sets SDP unit test

RFC 3984 sprop-parameter-sets SDP unit test

BUG=webrtc:5948
Committed: https://crrev.com/2d8d23eec2f43c0f75ccdf4c7c52855a7022b2b0
Cr-Commit-Position: refs/heads/master@{#13026}

[johan, 2016-05-30 15:36:19]

johan@webrtc.org changed reviewers:
+ sprang@webrtc.org

[sprang_webrtc, 2016-05-30 15:43:29]

sprang@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[sprang_webrtc, 2016-05-30 15:43:29]

lgtm with nits
+pthatcher as owner, ptal

https://codereview.webrtc.org/2023913002/diff/1/webrtc/api/webrtcsdp_unittest.cc
File webrtc/api/webrtcsdp_unittest.cc (right):

https://codereview.webrtc.org/2023913002/diff/1/webrtc/api/webrtcsdp_unittest...
webrtc/api/webrtcsdp_unittest.cc:2931: // Deserialize
End comments with a period. Though I don't think you need this comment at all.

https://codereview.webrtc.org/2023913002/diff/1/webrtc/api/webrtcsdp_unittest...
webrtc/api/webrtcsdp_unittest.cc:2937: ASSERT_TRUE(vc != NULL);
nullptr

[johan, 2016-05-30 15:57:06]

https://codereview.webrtc.org/2023913002/diff/1/webrtc/api/webrtcsdp_unittest.cc
File webrtc/api/webrtcsdp_unittest.cc (right):

https://codereview.webrtc.org/2023913002/diff/1/webrtc/api/webrtcsdp_unittest...
webrtc/api/webrtcsdp_unittest.cc:2931: // Deserialize
On 2016/05/30 15:43:29, språng wrote:
> End comments with a period. Though I don't think you need this comment at all.

Done.

https://codereview.webrtc.org/2023913002/diff/1/webrtc/api/webrtcsdp_unittest...
webrtc/api/webrtcsdp_unittest.cc:2937: ASSERT_TRUE(vc != NULL);
On 2016/05/30 15:43:29, språng wrote:
> nullptr

Done.

[pthatcher1, 2016-06-03 00:36:26]

lgtm

[johan, 2016-06-03 07:47:27]

The CQ bit was checked by johan@webrtc.org

[johan, 2016-06-03 07:47:28]

The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2023913002/#ps20001 (title:
"code review: comment + null ptr check")

[commit-bot: I haz the power, 2016-06-03 07:47:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2023913002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2023913002/20001

[commit-bot: I haz the power, 2016-06-03 08:22:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-03 08:22:57]

Description was changed from

==========
RFC 3984 sprop-parameter-sets SDP unit test

BUG=webrtc:5948
==========

to

==========
RFC 3984 sprop-parameter-sets SDP unit test

BUG=webrtc:5948

Committed: https://crrev.com/2d8d23eec2f43c0f75ccdf4c7c52855a7022b2b0
Cr-Commit-Position: refs/heads/master@{#13026}
==========

[commit-bot: I haz the power, 2016-06-03 08:22:58]

Patchset 2 (id:??) landed as
https://crrev.com/2d8d23eec2f43c0f75ccdf4c7c52855a7022b2b0
Cr-Commit-Position: refs/heads/master@{#13026}