Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2023233002: Revert of GN: Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc} (Closed)

Created:
4 years, 6 months ago by kjellander_webrtc
Modified:
4 years, 6 months ago
Reviewers:
tommi, perkj_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of GN: Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc} (patchset #5 id:80001 of https://codereview.webrtc.org/1979933002/ ) Reason for revert: Too many errors to address showed up when trying to land this with Chromium changes in https://codereview.chromium.org/2022833002/. Will address them separately before relanding. Original issue's description: > Reland of GN: Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc} > > Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc} in > preparation for removing src/third_party/libjingle in Chromium. > > Changes from previous attempt: > * Added libstunprober target > * Adjusted warnings for Chromium's clang plugins > * webrtc/pc/externalhmac.{h,cc} added for Chromium builds. > > As soon this has landed a roll including the changes in > https://codereview.chromium.org/2022833002/ is needed to make > Chromium build cleanly. > > BUG=webrtc:4256 > NOTRY=True > NOPRESUBMIT=True > > Committed: https://crrev.com/164e978f981c7810c4260c4184f41e26bae90230 > Cr-Commit-Position: refs/heads/master@{#12983} TBR=perkj@webrtc.org,tommi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4256 Committed: https://crrev.com/4d167e5ccde9e748488179b6dd3f26ccf35d7365 Cr-Commit-Position: refs/heads/master@{#12988}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -799 lines) Patch
M webrtc/BUILD.gn View 3 chunks +0 lines, -8 lines 0 comments Download
M webrtc/api/BUILD.gn View 1 chunk +0 lines, -127 lines 0 comments Download
M webrtc/build/webrtc.gni View 3 chunks +0 lines, -13 lines 0 comments Download
D webrtc/libjingle/xmllite/BUILD.gn View 1 chunk +0 lines, -54 lines 0 comments Download
D webrtc/libjingle/xmpp/BUILD.gn View 1 chunk +0 lines, -154 lines 0 comments Download
D webrtc/media/BUILD.gn View 1 chunk +0 lines, -206 lines 0 comments Download
D webrtc/p2p/BUILD.gn View 1 chunk +0 lines, -155 lines 0 comments Download
D webrtc/pc/BUILD.gn View 1 chunk +0 lines, -76 lines 0 comments Download
M webrtc/pc/pc.gyp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kjellander_webrtc
Created Revert of GN: Add BUILD.gn files for webrtc/{api,media,libjingle,p2p,pc}
4 years, 6 months ago (2016-06-01 11:44:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023233002/1
4 years, 6 months ago (2016-06-01 11:45:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 11:45:09 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 11:45:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d167e5ccde9e748488179b6dd3f26ccf35d7365
Cr-Commit-Position: refs/heads/master@{#12988}

Powered by Google App Engine
This is Rietveld 408576698