webrtc/base/messagequeue.h - Issue 2023193002: Protect MessageQueue stop field with a critical section to avoid data races.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/messagequeue.h

Issue 2023193002: Protect MessageQueue stop field with a critical section to avoid data races. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Clear suppresion is needed for vtable/destructor race Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/base/messagequeue.h

diff --git a/webrtc/base/messagequeue.h b/webrtc/base/messagequeue.h

index 15b98565b770e0eef60563c82e25d3ff4da03c07..d321cdb673e29fa5e51f962fb1173828b43d1eb9 100644

--- a/webrtc/base/messagequeue.h

+++ b/webrtc/base/messagequeue.h

@@ -285,7 +285,6 @@ class MessageQueue {

void WakeUpSocketServer();

- bool fStop_;

bool fPeekKeep_;

Message msgPeek_;

MessageList msgq_ GUARDED_BY(crit_);

@@ -296,6 +295,8 @@ class MessageQueue {

bool fDestroyed_;

private:

+ volatile int stop_;

// The SocketServer might not be owned by MessageQueue.

SocketServer* ss_ GUARDED_BY(ss_lock_);

// Used if SocketServer ownership lies with |this|.

« no previous file with comments | « no previous file | webrtc/base/messagequeue.cc » ('j') | webrtc/base/messagequeue.cc » ('J')