Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 2021843002: Delete unused code in webrtc_libyuv.cc. (Closed)

Created:
4 years, 6 months ago by nisse-webrtc
Modified:
4 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, sdk-team_agora.io, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused code in webrtc_libyuv.cc. Delete unused ConvertFromYV12, and dead prototypes ConvertRGB24ToARGB ConvertNV12ToRGB565. Move Calc16ByteAlignedStride to the test file where it is used. BUG= Committed: https://crrev.com/69adc9c7c0627f7c4f38084507bc9dfae09f305f Cr-Commit-Position: refs/heads/master@{#13003}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Copy Calc16ByteAlignedStride. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -115 lines) Patch
M webrtc/common_video/libyuv/include/webrtc_libyuv.h View 2 chunks +0 lines, -34 lines 0 comments Download
M webrtc/common_video/libyuv/libyuv_unittest.cc View 3 chunks +8 lines, -47 lines 0 comments Download
M webrtc/common_video/libyuv/webrtc_libyuv.cc View 3 chunks +0 lines, -30 lines 0 comments Download
M webrtc/modules/video_capture/video_capture_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc View 1 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
nisse-webrtc
Trying to prune unused functions from the webrtc_libyuv wrapper code.
4 years, 6 months ago (2016-05-30 12:46:15 UTC) #2
magjed_webrtc
lgtm
4 years, 6 months ago (2016-05-30 12:50:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021843002/1
4 years, 6 months ago (2016-05-30 13:01:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/5945)
4 years, 6 months ago (2016-05-30 13:27:27 UTC) #7
nisse-webrtc
PTAL, I need owners approval for these changes.
4 years, 6 months ago (2016-05-30 14:03:14 UTC) #9
pbos-webrtc
lgtm https://codereview.webrtc.org/2021843002/diff/1/webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc File webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc (right): https://codereview.webrtc.org/2021843002/diff/1/webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc#newcode135 webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:135: int stride_y = 16 * ((codec_inst_.width + 15) ...
4 years, 6 months ago (2016-05-31 10:48:45 UTC) #10
nisse-webrtc
https://codereview.webrtc.org/2021843002/diff/1/webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc File webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc (right): https://codereview.webrtc.org/2021843002/diff/1/webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc#newcode135 webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc:135: int stride_y = 16 * ((codec_inst_.width + 15) / ...
4 years, 6 months ago (2016-05-31 12:55:22 UTC) #11
perkj_webrtc
rs lgtm
4 years, 6 months ago (2016-06-01 20:07:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021843002/20001
4 years, 6 months ago (2016-06-02 06:58:30 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-02 07:58:40 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 07:58:47 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/69adc9c7c0627f7c4f38084507bc9dfae09f305f
Cr-Commit-Position: refs/heads/master@{#13003}

Powered by Google App Engine
This is Rietveld 408576698